2019-12-06 18:20:06

by Florian Fainelli

Subject: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells

The MDIO node on Cygnus had an reversed #address-cells and
#size-cells properties, correct those.

Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
Reported-by: Simon Horman <[email protected]>
Signed-off-by: Florian Fainelli <[email protected]>
---
arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
index 2dac3efc7640..1bc45cfd5453 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -174,8 +174,8 @@
mdio: mdio@18002000 {
compatible = "brcm,iproc-mdio";
reg = <0x18002000 0x8>;
- #size-cells = <1>;
- #address-cells = <0>;
+ #size-cells = <0>;
+ #address-cells = <1>;
status = "disabled";

gphy0: ethernet-phy@0 {
--
2.17.1

2019-12-07 00:56:32

by Ray Jui

Subject: Re: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells

On 12/6/19 10:19 AM, Florian Fainelli wrote:
> The MDIO node on Cygnus had an reversed #address-cells and
> #size-cells properties, correct those.
>
> Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
> Reported-by: Simon Horman <[email protected]>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---
> arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 2dac3efc7640..1bc45cfd5453 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -174,8 +174,8 @@
> mdio: mdio@18002000 {
> compatible = "brcm,iproc-mdio";
> reg = <0x18002000 0x8>;
> - #size-cells = <1>;
> - #address-cells = <0>;
> + #size-cells = <0>;
> + #address-cells = <1>;
> status = "disabled";
>
> gphy0: ethernet-phy@0 {
>

Looks good! Thanks!

Reviewed-by: Ray Jui <[email protected]>

2019-12-07 17:14:24

by Simon Horman

Subject: Re: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells

On Fri, Dec 06, 2019 at 10:19:09AM -0800, Florian Fainelli wrote:
> The MDIO node on Cygnus had an reversed #address-cells and
> #size-cells properties, correct those.
>
> Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
> Reported-by: Simon Horman <[email protected]>
> Signed-off-by: Florian Fainelli <[email protected]>

Thanks Florian,

this looks good to me.

Reviewed-by: Simon Horman <[email protected]>

> ---
> arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 2dac3efc7640..1bc45cfd5453 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -174,8 +174,8 @@
> mdio: mdio@18002000 {
> compatible = "brcm,iproc-mdio";
> reg = <0x18002000 0x8>;
> - #size-cells = <1>;
> - #address-cells = <0>;
> + #size-cells = <0>;
> + #address-cells = <1>;
> status = "disabled";
>
> gphy0: ethernet-phy@0 {
> --
> 2.17.1
>

2019-12-09 18:15:36

by Florian Fainelli

Subject: Re: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells

On Fri, 6 Dec 2019 10:19:09 -0800, Florian Fainelli <[email protected]> wrote:
> The MDIO node on Cygnus had an reversed #address-cells and
> #size-cells properties, correct those.
>
> Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
> Reported-by: Simon Horman <[email protected]>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---

Applied to devicetree/fixes, thanks!
--
Florian