2019-11-22 06:13:06

by Peng Fan

Subject: [PATCH] clk: imx: clk-imx7ulp: Add missing sentinel of ulp_div_table

From: Peng Fan <[email protected]>

There should be a sentinel of ulp_div_table, otherwise _get_table_div
may access data out of the array.

Fixes: b1260067ac3d ("clk: imx: add imx7ulp clk driver")
Signed-off-by: Peng Fan <[email protected]>
---
drivers/clk/imx/clk-imx7ulp.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx7ulp.c b/drivers/clk/imx/clk-imx7ulp.c
index 3fdf3d494f0a..281191b55b3a 100644
--- a/drivers/clk/imx/clk-imx7ulp.c
+++ b/drivers/clk/imx/clk-imx7ulp.c
@@ -40,6 +40,7 @@ static const struct clk_div_table ulp_div_table[] = {
{ .val = 5, .div = 16, },
{ .val = 6, .div = 32, },
{ .val = 7, .div = 64, },
+ { /* sentinel */ },
};

static const int pcc2_uart_clk_ids[] __initconst = {
--
2.16.4

2019-12-09 02:56:11

by Shawn Guo

Subject: Re: [PATCH] clk: imx: clk-imx7ulp: Add missing sentinel of ulp_div_table

On Fri, Nov 22, 2019 at 06:11:42AM +0000, Peng Fan wrote:
> From: Peng Fan <[email protected]>
>
> There should be a sentinel of ulp_div_table, otherwise _get_table_div
> may access data out of the array.
>
> Fixes: b1260067ac3d ("clk: imx: add imx7ulp clk driver")
> Signed-off-by: Peng Fan <[email protected]>

Applied, thanks.