With some minimal support on imx8mq we might as well add it to the DT
Changes from v1:
- Per review comments by Fabio Estevam
- Document compatible
- use lcd-controller instead of lcdif as node name
- Add Reviewed-by: from Fabio Estevam, thanks!
Guido Günther (2):
dt-bindings: mxsfb: Add compatible for iMX8MQ
arm64: dts: imx8mq: Add eLCDIF controller
.../devicetree/bindings/display/mxsfb.txt | 1 +
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 17 +++++++++++++++++
2 files changed, 18 insertions(+)
--
2.23.0
NXP's iMX8MQ has an LCDIF as well.
Signed-off-by: Guido Günther <[email protected]>
---
Documentation/devicetree/bindings/display/mxsfb.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt
index 472e1ea6c591..c985871c46b3 100644
--- a/Documentation/devicetree/bindings/display/mxsfb.txt
+++ b/Documentation/devicetree/bindings/display/mxsfb.txt
@@ -6,6 +6,7 @@ Required properties:
- compatible: Should be "fsl,imx23-lcdif" for i.MX23.
Should be "fsl,imx28-lcdif" for i.MX28.
Should be "fsl,imx6sx-lcdif" for i.MX6SX.
+ Should be "fsl,imx8mq-lcdif" for i.MX8MQ.
- reg: Address and length of the register set for LCDIF
- interrupts: Should contain LCDIF interrupt
- clocks: A list of phandle + clock-specifier pairs, one for each
--
2.23.0
Add a node for the eLCDIF controller, "disabled" by default.
Signed-off-by: Guido Günther <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 7f9319452b58..1fadd2b126a9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -448,6 +448,23 @@
fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
};
+ lcdif: lcd-controller@30320000 {
+ compatible = "fsl,imx8mq-lcdif", "fsl,imx28-lcdif";
+ reg = <0x30320000 0x10000>;
+ interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MQ_CLK_LCDIF_PIXEL>;
+ clock-names = "pix";
+ assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
+ <&clk IMX8MQ_VIDEO_PLL1_BYPASS>,
+ <&clk IMX8MQ_CLK_LCDIF_PIXEL>,
+ <&clk IMX8MQ_VIDEO_PLL1>;
+ assigned-clock-parents = <&clk IMX8MQ_CLK_25M>,
+ <&clk IMX8MQ_VIDEO_PLL1>,
+ <&clk IMX8MQ_VIDEO_PLL1_OUT>;
+ assigned-clock-rates = <0>, <0>, <0>, <594000000>;
+ status = "disabled";
+ };
+
iomuxc: iomuxc@30330000 {
compatible = "fsl,imx8mq-iomuxc";
reg = <0x30330000 0x10000>;
--
2.23.0
On Mon, Nov 25, 2019 at 11:50 AM Guido Günther <[email protected]> wrote:
>
> NXP's iMX8MQ has an LCDIF as well.
>
> Signed-off-by: Guido Günther <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
On Mon, 25 Nov 2019 15:50:06 +0100, =?UTF-8?q?Guido=20G=C3=BCnther?= wrote:
> NXP's iMX8MQ has an LCDIF as well.
>
> Signed-off-by: Guido G?nther <[email protected]>
> ---
> Documentation/devicetree/bindings/display/mxsfb.txt | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <[email protected]>
On Mon, Nov 25, 2019 at 03:50:05PM +0100, Guido G?nther wrote:
> With some minimal support on imx8mq we might as well add it to the DT
>
> Changes from v1:
> - Per review comments by Fabio Estevam
> - Document compatible
> - use lcd-controller instead of lcdif as node name
> - Add Reviewed-by: from Fabio Estevam, thanks!
>
> Guido G?nther (2):
> dt-bindings: mxsfb: Add compatible for iMX8MQ
> arm64: dts: imx8mq: Add eLCDIF controller
Applied both, thanks.