2019-12-09 16:23:07

by Chuhong Yuan

Subject: [PATCH] fjes: fix missed check in fjes_acpi_add

fjes_acpi_add() misses a check for platform_device_register_simple().
Add a check to fix it.

Fixes: 658d439b2292 ("fjes: Introduce FUJITSU Extended Socket Network Device driver")
Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/net/fjes/fjes_main.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index b517c1af9de0..91a1059517f5 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -166,6 +166,9 @@ static int fjes_acpi_add(struct acpi_device *device)
/* create platform_device */
plat_dev = platform_device_register_simple(DRV_NAME, 0, fjes_resource,
ARRAY_SIZE(fjes_resource));
+ if (IS_ERR(plat_dev))
+ return PTR_ERR(plat_dev);
+
device->driver_data = plat_dev;

return 0;
--
2.24.0

2019-12-09 22:42:46

by David Miller

Subject: Re: [PATCH] fjes: fix missed check in fjes_acpi_add

From: Chuhong Yuan <[email protected]>
Date: Tue, 10 Dec 2019 00:22:07 +0800

> fjes_acpi_add() misses a check for platform_device_register_simple().
> Add a check to fix it.
>
> Fixes: 658d439b2292 ("fjes: Introduce FUJITSU Extended Socket Network Device driver")
> Signed-off-by: Chuhong Yuan <[email protected]>

Applied.