2019-12-09 22:24:36

by Jaegeuk Kim

Subject: [PATCH 5/6] f2fs: set GFP_NOFS when moving inline dentries

Otherwise, it can cause circular locking dependency reported by mm.

Signed-off-by: Jaegeuk Kim <[email protected]>
---
fs/f2fs/inline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index 896db0416f0e..52f85ed07a15 100644
--- a/fs/f2fs/inline.c
+++ b/fs/f2fs/inline.c
@@ -368,7 +368,7 @@ static int f2fs_move_inline_dirents(struct inode *dir, struct page *ipage,
struct f2fs_dentry_ptr src, dst;
int err;

- page = f2fs_grab_cache_page(dir->i_mapping, 0, false);
+ page = f2fs_grab_cache_page(dir->i_mapping, 0, true);
if (!page) {
f2fs_put_page(ipage, 1);
return -ENOMEM;
--
2.19.0.605.g01d371f741-goog

2019-12-10 06:23:52

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH 5/6] f2fs: set GFP_NOFS when moving inline dentries

On 2019/12/10 6:23, Jaegeuk Kim wrote:
> Otherwise, it can cause circular locking dependency reported by mm.
>
> Signed-off-by: Jaegeuk Kim <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,