2019-12-03 13:13:52

by Martin Kepplinger

Subject: [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor

Now that there is driver support, describe the accel and gyro sensor parts
of the LSM9DS1 IMU.

Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index 683a11035643..7a92704c53ec 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -415,6 +415,13 @@
pinctrl-0 = <&pinctrl_i2c3>;
status = "okay";

+ accel_gyro@6a {
+ compatible = "st,lsm9ds1-imu";
+ reg = <0x6a>;
+ vdd-supply = <&reg_3v3_p>;
+ vddio-supply = <&reg_3v3_p>;
+ };
+
magnetometer@1e {
compatible = "st,lsm9ds1-magn";
reg = <0x1e>;
--
2.20.1

2019-12-10 09:10:29

by Martin Kepplinger

Subject: [PATCH] arm64: dts: imx8mq-librem5-devkit: use correct interrupt for the magnetometer

From: "Angus Ainslie (Purism)" <[email protected]>

The LSM9DS1 uses a high level interrupt.

Signed-off-by: Angus Ainslie (Purism) <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---

Any objections or questions about the previously sent accelerometer DT
description? It and this follow-up bugfix is what we're running for
quite some time now.

thanks,

martin



arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index 2834d273bfdf..8de24a2d5234 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -429,7 +429,7 @@
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_imu>;
interrupt-parent = <&gpio3>;
- interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
+ interrupts = <19 IRQ_TYPE_LEVEL_HIGH>;
vdd-supply = <&reg_3v3_p>;
vddio-supply = <&reg_3v3_p>;
};
--
2.20.1

2019-12-23 07:20:45

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor

On Mon, Dec 16, 2019 at 10:32:15AM +0100, Martin Kepplinger wrote:
> On 03.12.19 14:03, Martin Kepplinger wrote:
> > Now that there is driver support, describe the accel and gyro sensor parts
> > of the LSM9DS1 IMU.
> >
> > Signed-off-by: Martin Kepplinger <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > index 683a11035643..7a92704c53ec 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > @@ -415,6 +415,13 @@
> > pinctrl-0 = <&pinctrl_i2c3>;
> > status = "okay";
> >
> > + accel_gyro@6a {

We prefer to use hyphen than underscore in node name. Also nodes with
unit-address should be sorted in the address.

Shawn

> > + compatible = "st,lsm9ds1-imu";
> > + reg = <0x6a>;
> > + vdd-supply = <&reg_3v3_p>;
> > + vddio-supply = <&reg_3v3_p>;
> > + };
> > +
> > magnetometer@1e {
> > compatible = "st,lsm9ds1-magn";
> > reg = <0x1e>;
> >
>
> (adding / fixing people in CC)
>
> Are there any questions about this addition or the followup fix?
>
> thanks a lot,
>
> martin

2019-12-23 08:15:53

by Martin Kepplinger

Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor

On 23.12.19 08:18, Shawn Guo wrote:
> On Mon, Dec 16, 2019 at 10:32:15AM +0100, Martin Kepplinger wrote:
>> On 03.12.19 14:03, Martin Kepplinger wrote:
>>> Now that there is driver support, describe the accel and gyro sensor parts
>>> of the LSM9DS1 IMU.
>>>
>>> Signed-off-by: Martin Kepplinger <[email protected]>
>>> ---
>>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> index 683a11035643..7a92704c53ec 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> @@ -415,6 +415,13 @@
>>> pinctrl-0 = <&pinctrl_i2c3>;
>>> status = "okay";
>>>
>>> + accel_gyro@6a {
>
> We prefer to use hyphen than underscore in node name. Also nodes with
> unit-address should be sorted in the address.
>
> Shawn

thanks a lot for taking a look. resent.

martin