2019-12-10 14:50:08

by Mihail Atanassov

Subject: [PATCH] drm/bridge: panel: export drm_panel_bridge_connector

The function was unexported and was causing link failures for pl111 (and
probably the other user tve200) in a module build.

Fixes: d383fb5f8add ("drm: get drm_bridge_panel connector via helper")
Cc: Sam Ravnborg <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Linux Walleij <[email protected]>
Signed-off-by: Mihail Atanassov <[email protected]>
---
drivers/gpu/drm/bridge/panel.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 1443897f999b..f66777e24968 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -306,3 +306,4 @@ struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge)

return &panel_bridge->connector;
}
+EXPORT_SYMBOL(drm_panel_bridge_connector);
--
2.23.0

2019-12-10 16:27:43

by Laurent Pinchart

Subject: Re: [PATCH] drm/bridge: panel: export drm_panel_bridge_connector

Hi Mihail,

Thank you for the patch.

On Tue, Dec 10, 2019 at 02:48:49PM +0000, Mihail Atanassov wrote:
> The function was unexported and was causing link failures for pl111 (and
> probably the other user tve200) in a module build.
>
> Fixes: d383fb5f8add ("drm: get drm_bridge_panel connector via helper")
> Cc: Sam Ravnborg <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Cc: Linux Walleij <[email protected]>
> Signed-off-by: Mihail Atanassov <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/panel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 1443897f999b..f66777e24968 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -306,3 +306,4 @@ struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge)
>
> return &panel_bridge->connector;
> }
> +EXPORT_SYMBOL(drm_panel_bridge_connector);

--
Regards,

Laurent Pinchart

2019-12-10 17:29:37

by Mihail Atanassov

Subject: Re: [PATCH] drm/bridge: panel: export drm_panel_bridge_connector

On Tuesday, 10 December 2019 16:26:47 GMT Laurent Pinchart wrote:
> Hi Mihail,
>
> Thank you for the patch.
>
> On Tue, Dec 10, 2019 at 02:48:49PM +0000, Mihail Atanassov wrote:
> > The function was unexported and was causing link failures for pl111 (and
> > probably the other user tve200) in a module build.
> >
> > Fixes: d383fb5f8add ("drm: get drm_bridge_panel connector via helper")
> > Cc: Sam Ravnborg <[email protected]>
> > Cc: Laurent Pinchart <[email protected]>
> > Cc: Linux Walleij <[email protected]>
> > Signed-off-by: Mihail Atanassov <[email protected]>
>
> Reviewed-by: Laurent Pinchart <[email protected]>
>

Thanks, applied to drm-misc-next.

> > ---
> > drivers/gpu/drm/bridge/panel.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > index 1443897f999b..f66777e24968 100644
> > --- a/drivers/gpu/drm/bridge/panel.c
> > +++ b/drivers/gpu/drm/bridge/panel.c
> > @@ -306,3 +306,4 @@ struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge)
> >
> > return &panel_bridge->connector;
> > }
> > +EXPORT_SYMBOL(drm_panel_bridge_connector);
>
> --
> Regards,
>
> Laurent Pinchart
>


--
Mihail