As Jakub Kicinski suggested in ethtool netlink v7 discussion, this
submission consists only of preliminary patches which raised no objections;
first four patches already have Acked-by or Reviewed-by.
- patch 1 exposes permanent hardware address (as shown by "ethtool -P")
via rtnetlink
- patch 2 is renames existing netlink helper to a better name
- patch 3 and 4 reorganize existing ethtool code (no functional change)
- patch 5 makes the table of link mode names available as an ethtool string
set (will be needed for the netlink interface)
Once we get these out of the way, v8 of the first part of the ethtool
netlink interface will follow.
Changes from v2 to v3: fix SPDX licence identifiers (patch 3 and 5).
Changes from v1 to v2: restore build time check that all link modes have
assigned a name (patch 5).
Michal Kubecek (5):
rtnetlink: provide permanent hardware address in RTM_NEWLINK
netlink: rename nl80211_validate_nested() to nla_validate_nested()
ethtool: move to its own directory
ethtool: move string arrays into common file
ethtool: provide link mode names as a string set
include/net/netlink.h | 8 +-
include/uapi/linux/ethtool.h | 2 +
include/uapi/linux/if_link.h | 1 +
net/Makefile | 2 +-
net/core/Makefile | 2 +-
net/core/rtnetlink.c | 5 +
net/ethtool/Makefile | 3 +
net/ethtool/common.c | 171 ++++++++++++++++++++++++
net/ethtool/common.h | 22 +++
net/{core/ethtool.c => ethtool/ioctl.c} | 90 ++-----------
net/wireless/nl80211.c | 3 +-
11 files changed, 219 insertions(+), 90 deletions(-)
create mode 100644 net/ethtool/Makefile
create mode 100644 net/ethtool/common.c
create mode 100644 net/ethtool/common.h
rename net/{core/ethtool.c => ethtool/ioctl.c} (95%)
--
2.24.0
On Wed, 11 Dec 2019 10:58:09 +0100 (CET), Michal Kubecek wrote:
> As Jakub Kicinski suggested in ethtool netlink v7 discussion, this
> submission consists only of preliminary patches which raised no objections;
> first four patches already have Acked-by or Reviewed-by.
>
> - patch 1 exposes permanent hardware address (as shown by "ethtool -P")
> via rtnetlink
> - patch 2 is renames existing netlink helper to a better name
> - patch 3 and 4 reorganize existing ethtool code (no functional change)
> - patch 5 makes the table of link mode names available as an ethtool string
> set (will be needed for the netlink interface)
Reviewed-by: Jakub Kicinski <[email protected]>
On 12/11/2019 1:58 AM, Michal Kubecek wrote:
> As Jakub Kicinski suggested in ethtool netlink v7 discussion, this
> submission consists only of preliminary patches which raised no objections;
> first four patches already have Acked-by or Reviewed-by.
Good strategy, let's make sure we can land the entire ethtool over
netlink for v5.6, that would be a great milestone and would open up the
door for quite a lot of development. Thanks for your persistence on the
subject, because this is anything but fun.
--
Florian
From: Michal Kubecek <[email protected]>
Date: Wed, 11 Dec 2019 10:58:09 +0100 (CET)
> As Jakub Kicinski suggested in ethtool netlink v7 discussion, this
> submission consists only of preliminary patches which raised no objections;
> first four patches already have Acked-by or Reviewed-by.
>
> - patch 1 exposes permanent hardware address (as shown by "ethtool -P")
> via rtnetlink
> - patch 2 is renames existing netlink helper to a better name
> - patch 3 and 4 reorganize existing ethtool code (no functional change)
> - patch 5 makes the table of link mode names available as an ethtool string
> set (will be needed for the netlink interface)
>
> Once we get these out of the way, v8 of the first part of the ethtool
> netlink interface will follow.
>
> Changes from v2 to v3: fix SPDX licence identifiers (patch 3 and 5).
>
> Changes from v1 to v2: restore build time check that all link modes have
> assigned a name (patch 5).
Series applied to net-next, thanks.