From: Ed Maste <[email protected]>
In 7fcfa9a2d9 an unintended prefix "Counter:18 Name:" was removed from
the description for L1D_RO_EXCL_WRITES, but the extra name remained in
the description. Remove it too.
Signed-off-by: Ed Maste <[email protected]>
---
tools/perf/pmu-events/arch/s390/cf_z14/extended.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/pmu-events/arch/s390/cf_z14/extended.json b/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
index e6478dff0af7..4942b20a1ea1 100644
--- a/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
+++ b/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
@@ -4,7 +4,7 @@
"EventCode": "128",
"EventName": "L1D_RO_EXCL_WRITES",
"BriefDescription": "L1D Read-only Exclusive Writes",
- "PublicDescription": "L1D_RO_EXCL_WRITES A directory write to the Level-1 Data cache where the line was originally in a Read-Only state in the cache but has been updated to be in the Exclusive state that allows stores to the cache line"
+ "PublicDescription": "A directory write to the Level-1 Data cache where the line was originally in a Read-Only state in the cache but has been updated to be in the Exclusive state that allows stores to the cache line"
},
{
"Unit": "CPU-M-CF",
--
2.24.0
Em Thu, Dec 12, 2019 at 02:53:46PM +0000, Ed Maste escreveu:
> From: Ed Maste <[email protected]>
>
> In 7fcfa9a2d9 an unintended prefix "Counter:18 Name:" was removed from
> the description for L1D_RO_EXCL_WRITES, but the extra name remained in
> the description. Remove it too.
Also trivially correct, applied and added a Fixes tag with that cset
(7fcfa9a2d9).
- Arnaldo
> Signed-off-by: Ed Maste <[email protected]>
> ---
> tools/perf/pmu-events/arch/s390/cf_z14/extended.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/arch/s390/cf_z14/extended.json b/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
> index e6478dff0af7..4942b20a1ea1 100644
> --- a/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
> +++ b/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
> @@ -4,7 +4,7 @@
> "EventCode": "128",
> "EventName": "L1D_RO_EXCL_WRITES",
> "BriefDescription": "L1D Read-only Exclusive Writes",
> - "PublicDescription": "L1D_RO_EXCL_WRITES A directory write to the Level-1 Data cache where the line was originally in a Read-Only state in the cache but has been updated to be in the Exclusive state that allows stores to the cache line"
> + "PublicDescription": "A directory write to the Level-1 Data cache where the line was originally in a Read-Only state in the cache but has been updated to be in the Exclusive state that allows stores to the cache line"
> },
> {
> "Unit": "CPU-M-CF",
> --
> 2.24.0
--
- Arnaldo
On Thu, 12 Dec 2019 at 13:02, Arnaldo Carvalho de Melo
<[email protected]> wrote:
>
> Em Thu, Dec 12, 2019 at 02:53:46PM +0000, Ed Maste escreveu:
> > From: Ed Maste <[email protected]>
> >
> > In 7fcfa9a2d9 an unintended prefix "Counter:18 Name:" was removed from
> > the description for L1D_RO_EXCL_WRITES, but the extra name remained in
> > the description. Remove it too.
>
> Also trivially correct, applied and added a Fixes tag with that cset
> (7fcfa9a2d9).
>
> - Arnaldo
Thank you, and sorry that these came not as a set. Each time I thought
I had only one change to submit and then found another nit shortly
after I sent the previous.
There is one more related change that hasn't been picked up yet (and
that I seem to have missed adding you on CC), with subject
[PATCH] perf vendor events s390: Fix commas so PMU event files are valid JSON