2019-12-14 07:46:32

by Chuhong Yuan

Subject: [PATCH] rtc: asm9260: add the missed check for devm_clk_get

The driver misses a check for devm_clk_get().
Add the check to fix it.

Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/rtc/rtc-asm9260.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/rtc/rtc-asm9260.c b/drivers/rtc/rtc-asm9260.c
index 10064bdabdff..3ab81cdec00b 100644
--- a/drivers/rtc/rtc-asm9260.c
+++ b/drivers/rtc/rtc-asm9260.c
@@ -264,6 +264,9 @@ static int asm9260_rtc_probe(struct platform_device *pdev)
return PTR_ERR(priv->iobase);

priv->clk = devm_clk_get(dev, "ahb");
+ if (IS_ERR(priv->clk))
+ return PTR_ERR(priv->clk);
+
ret = clk_prepare_enable(priv->clk);
if (ret) {
dev_err(dev, "Failed to enable clk!\n");
--
2.24.0

2019-12-23 10:09:49

by Alexandre Belloni

Subject: Re: [PATCH] rtc: asm9260: add the missed check for devm_clk_get

On 14/12/2019 15:45:28+0800, Chuhong Yuan wrote:
> The driver misses a check for devm_clk_get().
> Add the check to fix it.
>
> Signed-off-by: Chuhong Yuan <[email protected]>
> ---
> drivers/rtc/rtc-asm9260.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com