2019-12-14 18:12:45

by Frank Lee

Subject: [PATCH 1/2] PM / devfreq: rockchip-dfi: add missing of_node_put()

of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.

Signed-off-by: Yangtao Li <[email protected]>
---
drivers/devfreq/event/rockchip-dfi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
index 5d1042188727..45b190e443d8 100644
--- a/drivers/devfreq/event/rockchip-dfi.c
+++ b/drivers/devfreq/event/rockchip-dfi.c
@@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
node = of_parse_phandle(np, "rockchip,pmu", 0);
if (node) {
data->regmap_pmu = syscon_node_to_regmap(node);
+ of_node_put(node);
if (IS_ERR(data->regmap_pmu))
return PTR_ERR(data->regmap_pmu);
}
--
2.17.1

2019-12-15 15:32:54

by Chanwoo Choi

Subject: Re: [PATCH 1/2] PM / devfreq: rockchip-dfi: add missing of_node_put()

2019년 12월 15일 (일) 오전 3:12, Yangtao Li <[email protected]>님이 작성:
>
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> drivers/devfreq/event/rockchip-dfi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
> index 5d1042188727..45b190e443d8 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
> node = of_parse_phandle(np, "rockchip,pmu", 0);
> if (node) {
> data->regmap_pmu = syscon_node_to_regmap(node);
> + of_node_put(node);
> if (IS_ERR(data->regmap_pmu))
> return PTR_ERR(data->regmap_pmu);
> }
> --
> 2.17.1
>

Applied it. Better to use the capital letter for first char of sentence.

--
Best Regards,
Chanwoo Choi

2019-12-15 15:43:14

by Frank Lee

Subject: Re: [PATCH 1/2] PM / devfreq: rockchip-dfi: add missing of_node_put()

On Sun, Dec 15, 2019 at 11:31 PM Chanwoo Choi <[email protected]> wrote:
>
> 2019년 12월 15일 (일) 오전 3:12, Yangtao Li <[email protected]>님이 작성:
> >
> > of_node_put needs to be called when the device node which is got
> > from of_parse_phandle has finished using.
> >
> > Signed-off-by: Yangtao Li <[email protected]>
> > ---
> > drivers/devfreq/event/rockchip-dfi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
> > index 5d1042188727..45b190e443d8 100644
> > --- a/drivers/devfreq/event/rockchip-dfi.c
> > +++ b/drivers/devfreq/event/rockchip-dfi.c
> > @@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
> > node = of_parse_phandle(np, "rockchip,pmu", 0);
> > if (node) {
> > data->regmap_pmu = syscon_node_to_regmap(node);
> > + of_node_put(node);
> > if (IS_ERR(data->regmap_pmu))
> > return PTR_ERR(data->regmap_pmu);
> > }
> > --
> > 2.17.1
> >
>
> Applied it. Better to use the capital letter for first char of sentence.

Thx!

Yangtao

>
> --
> Best Regards,
> Chanwoo Choi