2019-12-19 07:49:52

by Chuhong Yuan

Subject: [PATCH v2 RFT] media: exynos4-is: add missed clk_disable_unprepare in remove

This driver forgets to disable and unprepare clock when remove.
Add a call to clk_disable_unprepare() to fix it.

Signed-off-by: Chuhong Yuan <[email protected]>
---
Changes in v2:
- Add a check of pm_runtime_enable() to match enable in probe.
- Add RFT tag.

drivers/media/platform/exynos4-is/fimc-lite.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/media/platform/exynos4-is/fimc-lite.c b/drivers/media/platform/exynos4-is/fimc-lite.c
index e87c6a09205b..17de14fbba31 100644
--- a/drivers/media/platform/exynos4-is/fimc-lite.c
+++ b/drivers/media/platform/exynos4-is/fimc-lite.c
@@ -1614,6 +1614,9 @@ static int fimc_lite_remove(struct platform_device *pdev)
struct fimc_lite *fimc = platform_get_drvdata(pdev);
struct device *dev = &pdev->dev;

+ if (!pm_runtime_enabled(dev))
+ clk_disable_unprepare(fimc->clock);
+
pm_runtime_disable(dev);
pm_runtime_set_suspended(dev);
fimc_lite_unregister_capture_subdev(fimc);
--
2.24.0

2020-01-10 13:41:50

by Hans Verkuil

Subject: Re: [PATCH v2 RFT] media: exynos4-is: add missed clk_disable_unprepare in remove

Anyone able/willing to test this patch?

Regards,

Hans

On 12/19/19 8:48 AM, Chuhong Yuan wrote:
> This driver forgets to disable and unprepare clock when remove.
> Add a call to clk_disable_unprepare() to fix it.
>
> Signed-off-by: Chuhong Yuan <[email protected]>
> ---
> Changes in v2:
> - Add a check of pm_runtime_enable() to match enable in probe.
> - Add RFT tag.
>
> drivers/media/platform/exynos4-is/fimc-lite.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/exynos4-is/fimc-lite.c b/drivers/media/platform/exynos4-is/fimc-lite.c
> index e87c6a09205b..17de14fbba31 100644
> --- a/drivers/media/platform/exynos4-is/fimc-lite.c
> +++ b/drivers/media/platform/exynos4-is/fimc-lite.c
> @@ -1614,6 +1614,9 @@ static int fimc_lite_remove(struct platform_device *pdev)
> struct fimc_lite *fimc = platform_get_drvdata(pdev);
> struct device *dev = &pdev->dev;
>
> + if (!pm_runtime_enabled(dev))
> + clk_disable_unprepare(fimc->clock);
> +
> pm_runtime_disable(dev);
> pm_runtime_set_suspended(dev);
> fimc_lite_unregister_capture_subdev(fimc);
>

2020-01-13 07:53:19

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 RFT] media: exynos4-is: add missed clk_disable_unprepare in remove

On Fri, Jan 10, 2020 at 02:40:21PM +0100, Hans Verkuil wrote:
> Anyone able/willing to test this patch?

I do not have the hardware with FIMC/camera so I cannot provide testing.
However it looks good, so I propose to just take it:
Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof