2019-12-19 11:52:58

by Khouloud Touil

Subject: [PATCH v3 3/4] dt-bindings: at24: remove the optional property write-protect-gpios

NVMEM framework is an interface for the at24 EEPROMs as well as for
other drivers, instead of passing the wp-gpios over the different
drivers each time, it would be better to pass it over the NVMEM
subsystem once and for all.

Removing the optional property form the device tree binding document.

Signed-off-by: Khouloud Touil <[email protected]>
Reviewed-by: Linus Walleij <[email protected]>
---
Documentation/devicetree/bindings/eeprom/at24.yaml | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
index e8778560d966..75de83708146 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.yaml
+++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
@@ -145,10 +145,7 @@ properties:
over reads to the next slave address. Please consult the manual of
your device.

- wp-gpios:
- description:
- GPIO to which the write-protect pin of the chip is connected.
- maxItems: 1
+ wp-gpios: true

address-width:
allOf:
@@ -181,7 +178,6 @@ examples:
compatible = "microchip,24c32", "atmel,24c32";
reg = <0x52>;
pagesize = <32>;
- wp-gpios = <&gpio1 3 0>;
num-addresses = <8>;
};
};
--
2.17.1

2020-01-03 23:45:31

by Rob Herring (Arm)

Subject: Re: [PATCH v3 3/4] dt-bindings: at24: remove the optional property write-protect-gpios

On Thu, Dec 19, 2019 at 12:51:40PM +0100, Khouloud Touil wrote:
> NVMEM framework is an interface for the at24 EEPROMs as well as for
> other drivers, instead of passing the wp-gpios over the different
> drivers each time, it would be better to pass it over the NVMEM
> subsystem once and for all.
>
> Removing the optional property form the device tree binding document.
>
> Signed-off-by: Khouloud Touil <[email protected]>
> Reviewed-by: Linus Walleij <[email protected]>
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index e8778560d966..75de83708146 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -145,10 +145,7 @@ properties:
> over reads to the next slave address. Please consult the manual of
> your device.
>
> - wp-gpios:
> - description:
> - GPIO to which the write-protect pin of the chip is connected.
> - maxItems: 1
> + wp-gpios: true
>
> address-width:
> allOf:
> @@ -181,7 +178,6 @@ examples:
> compatible = "microchip,24c32", "atmel,24c32";
> reg = <0x52>;
> pagesize = <32>;
> - wp-gpios = <&gpio1 3 0>;

This is still valid, why is it being removed?

> num-addresses = <8>;
> };
> };
> --
> 2.17.1
>