2019-12-20 06:54:18

by Lubomir Rintel

Subject: [PATCH 3/5] dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy

This is the PHY chip for USB HSIC on MMP3 platform.

Signed-off-by: Lubomir Rintel <[email protected]>
---
.../bindings/phy/marvell,mmp3-hsic-phy.yaml | 41 +++++++++++++++++++
1 file changed, 41 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml

diff --git a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
new file mode 100644
index 0000000000000..7917a95cda78d
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# Copyright 2019 Lubomir Rintel <[email protected]>
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/phy/marvell,mmp3-hsic-phy.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Marvell MMP3 HSIC PHY
+
+maintainers:
+ - Lubomir Rintel <[email protected]>
+
+properties:
+ compatible:
+ const: marvell,mmp3-hsic-phy
+
+ reg:
+ maxItems: 1
+ description: base address of the device
+
+ reset-gpios:
+ maxItems: 1
+ description: GPIO connected to reset
+
+ "#phy-cells":
+ const: 0
+
+required:
+ - compatible
+ - reg
+ - reset-gpios
+ - "#phy-cells"
+
+examples:
+ - |
+ hsic-phy@f0001800 {
+ compatible = "marvell,mmp3-hsic-phy";
+ reg = <0xf0001800 0x40>;
+ reset-gpios = <&gpio 63 GPIO_ACTIVE_HIGH>;
+ #phy-cells = <0>;
+ };
--
2.24.1

2020-01-07 22:23:16

by Rob Herring

Subject: Re: [PATCH 3/5] dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy

On Fri, Dec 20, 2019 at 1:01 AM Lubomir Rintel <[email protected]> wrote:
>
> This is the PHY chip for USB HSIC on MMP3 platform.
>
> Signed-off-by: Lubomir Rintel <[email protected]>
> ---
> .../bindings/phy/marvell,mmp3-hsic-phy.yaml | 41 +++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml

Seems this is already in -next, but it breaks dt_binding_check.

>
> diff --git a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
> new file mode 100644
> index 0000000000000..7917a95cda78d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later

Dual license new bindings:

(GPL-2.0-only OR BSD-2-Clause)

> +# Copyright 2019 Lubomir Rintel <[email protected]>
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/phy/marvell,mmp3-hsic-phy.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Marvell MMP3 HSIC PHY
> +
> +maintainers:
> + - Lubomir Rintel <[email protected]>
> +
> +properties:
> + compatible:
> + const: marvell,mmp3-hsic-phy
> +
> + reg:
> + maxItems: 1
> + description: base address of the device

Drop description. That's *every* 'reg' property.

> +
> + reset-gpios:
> + maxItems: 1
> + description: GPIO connected to reset
> +
> + "#phy-cells":
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - reset-gpios
> + - "#phy-cells"
> +
> +examples:
> + - |
> + hsic-phy@f0001800 {
> + compatible = "marvell,mmp3-hsic-phy";
> + reg = <0xf0001800 0x40>;
> + reset-gpios = <&gpio 63 GPIO_ACTIVE_HIGH>;

Examples are built now and this one doesn't. You need the include for
the define. Check with 'make dt_binding_check'.

> + #phy-cells = <0>;
> + };
> --
> 2.24.1
>