2019-12-13 21:39:29

by Tomasz Duszynski

Subject: [PATCH] iio: chemical: pms7003: fix unmet triggered buffer dependency

IIO triggered buffer depends on IIO buffer which is missing from Kconfig
file. This should go unnoticed most of the time because there's a
chance something else has already enabled buffers. In some rare cases
though one might experience kbuild warnings about unmet direct
dependencies and build failures due to missing symbols.

Fix this by selecting IIO_BUFFER explicitly.

Signed-off-by: Tomasz Duszynski <[email protected]>
---
drivers/iio/chemical/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
index fa4586037bb8..0b91de4df8f4 100644
--- a/drivers/iio/chemical/Kconfig
+++ b/drivers/iio/chemical/Kconfig
@@ -65,6 +65,7 @@ config IAQCORE
config PMS7003
tristate "Plantower PMS7003 particulate matter sensor"
depends on SERIAL_DEV_BUS
+ select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
help
Say Y here to build support for the Plantower PMS7003 particulate
--
2.24.1

2019-12-23 16:41:39

by Jonathan Cameron

Subject: Re: [PATCH] iio: chemical: pms7003: fix unmet triggered buffer dependency

On Fri, 13 Dec 2019 22:38:08 +0100
Tomasz Duszynski <[email protected]> wrote:

> IIO triggered buffer depends on IIO buffer which is missing from Kconfig
> file. This should go unnoticed most of the time because there's a
> chance something else has already enabled buffers. In some rare cases
> though one might experience kbuild warnings about unmet direct
> dependencies and build failures due to missing symbols.
>
> Fix this by selecting IIO_BUFFER explicitly.
>
> Signed-off-by: Tomasz Duszynski <[email protected]>
Applied to the fixes-togreg branch of iio.git. Marked for stable and
with the addition of a fixes tag.

Thanks,

Jonathan

> ---
> drivers/iio/chemical/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
> index fa4586037bb8..0b91de4df8f4 100644
> --- a/drivers/iio/chemical/Kconfig
> +++ b/drivers/iio/chemical/Kconfig
> @@ -65,6 +65,7 @@ config IAQCORE
> config PMS7003
> tristate "Plantower PMS7003 particulate matter sensor"
> depends on SERIAL_DEV_BUS
> + select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> help
> Say Y here to build support for the Plantower PMS7003 particulate