2019-12-24 21:14:20

by Hyunki Koo

[permalink] [raw]
Subject: [PATCH] irqchip: define EXYNOS_IRQ_COMBINER

From: Hyunki Koo <[email protected]>

This patch is written to clean up dependency of ARCH_EXYNOS
Not all exynos device have IRQ_COMBINER, especially aarch64 EXYNOS
but it is built for all exynos devices.
Thus add the config for EXYNOS_IRQ_COMBINER
remove direct dependency between ARCH_EXYNOS and exynos-combiner.c
and only selected on the aarch32 devices

Signed-off-by: Hyunki Koo <[email protected]>
---
arch/arm/mach-exynos/Kconfig | 1 +
drivers/irqchip/Kconfig | 7 +++++++
drivers/irqchip/Makefile | 2 +-
3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 4ef56571145b..6e7f10c8098a 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -12,6 +12,7 @@ menuconfig ARCH_EXYNOS
select ARCH_SUPPORTS_BIG_ENDIAN
select ARM_AMBA
select ARM_GIC
+ select EXYNOS_IRQ_COMBINER
select COMMON_CLK_SAMSUNG
select EXYNOS_ASV
select EXYNOS_CHIPID
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index ba152954324b..4c774d85375b 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -499,4 +499,11 @@ config SIFIVE_PLIC

If you don't know what to do here, say Y.

+config EXYNOS_IRQ_COMBINER
+ bool "Samsung Exynos IRQ combiner support" if COMPILE_TEST
+ depends on (ARCH_EXYNOS && ARM) || COMPILE_TEST
+ help
+ Say yes here to add support for the IRQ combiner devices embedded
+ in Samsung Exynos chips.
+
endmenu
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index e806dda690ea..60d7c7260fc3 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -9,7 +9,7 @@ obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2835.o
obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2836.o
obj-$(CONFIG_DAVINCI_AINTC) += irq-davinci-aintc.o
obj-$(CONFIG_DAVINCI_CP_INTC) += irq-davinci-cp-intc.o
-obj-$(CONFIG_ARCH_EXYNOS) += exynos-combiner.o
+obj-$(CONFIG_EXYNOS_IRQ_COMBINER) += exynos-combiner.o
obj-$(CONFIG_FARADAY_FTINTC010) += irq-ftintc010.o
obj-$(CONFIG_ARCH_HIP04) += irq-hip04.o
obj-$(CONFIG_ARCH_LPC32XX) += irq-lpc32xx.o
--
2.17.1


2019-12-29 16:41:39

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] irqchip: define EXYNOS_IRQ_COMBINER

On Wed, Dec 25, 2019 at 06:11:07AM +0900, Hyunki Koo wrote:
> From: Hyunki Koo <[email protected]>
>
> This patch is written to clean up dependency of ARCH_EXYNOS
> Not all exynos device have IRQ_COMBINER, especially aarch64 EXYNOS
> but it is built for all exynos devices.
> Thus add the config for EXYNOS_IRQ_COMBINER
> remove direct dependency between ARCH_EXYNOS and exynos-combiner.c
> and only selected on the aarch32 devices
>
> Signed-off-by: Hyunki Koo <[email protected]>
> ---
> arch/arm/mach-exynos/Kconfig | 1 +
> drivers/irqchip/Kconfig | 7 +++++++
> drivers/irqchip/Makefile | 2 +-
> 3 files changed, 9 insertions(+), 1 deletion(-)

I assume it will go through irqchip tree:
Reviewed-by: Krzysztof Kozlowski <[email protected]>

If not, let me know, so I could take it via samsung-soc.

Best regards,
Krzysztof

Subject: [tip: irq/core] irqchip: Define EXYNOS_IRQ_COMBINER

The following commit has been merged into the irq/core branch of tip:

Commit-ID: b74416dba33be3ed934e21df8286076cbd85b97f
Gitweb: https://git.kernel.org/tip/b74416dba33be3ed934e21df8286076cbd85b97f
Author: Hyunki Koo <[email protected]>
AuthorDate: Wed, 25 Dec 2019 06:11:07 +09:00
Committer: Marc Zyngier <[email protected]>
CommitterDate: Mon, 20 Jan 2020 19:10:05

irqchip: Define EXYNOS_IRQ_COMBINER

This patch is written to clean up dependency of ARCH_EXYNOS
Not all exynos device have IRQ_COMBINER, especially aarch64 EXYNOS
but it is built for all exynos devices.
Thus add the config for EXYNOS_IRQ_COMBINER
remove direct dependency between ARCH_EXYNOS and exynos-combiner.c
and only selected on the aarch32 devices

Signed-off-by: Hyunki Koo <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
arch/arm/mach-exynos/Kconfig | 1 +
drivers/irqchip/Kconfig | 7 +++++++
drivers/irqchip/Makefile | 2 +-
3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 4ef5657..6e7f10c 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -12,6 +12,7 @@ menuconfig ARCH_EXYNOS
select ARCH_SUPPORTS_BIG_ENDIAN
select ARM_AMBA
select ARM_GIC
+ select EXYNOS_IRQ_COMBINER
select COMMON_CLK_SAMSUNG
select EXYNOS_ASV
select EXYNOS_CHIPID
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index bb89dfc..20c62d7 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -500,4 +500,11 @@ config SIFIVE_PLIC

If you don't know what to do here, say Y.

+config EXYNOS_IRQ_COMBINER
+ bool "Samsung Exynos IRQ combiner support" if COMPILE_TEST
+ depends on (ARCH_EXYNOS && ARM) || COMPILE_TEST
+ help
+ Say yes here to add support for the IRQ combiner devices embedded
+ in Samsung Exynos chips.
+
endmenu
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index 6c9262c..4b1c511 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -9,7 +9,7 @@ obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2835.o
obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2836.o
obj-$(CONFIG_DAVINCI_AINTC) += irq-davinci-aintc.o
obj-$(CONFIG_DAVINCI_CP_INTC) += irq-davinci-cp-intc.o
-obj-$(CONFIG_ARCH_EXYNOS) += exynos-combiner.o
+obj-$(CONFIG_EXYNOS_IRQ_COMBINER) += exynos-combiner.o
obj-$(CONFIG_FARADAY_FTINTC010) += irq-ftintc010.o
obj-$(CONFIG_ARCH_HIP04) += irq-hip04.o
obj-$(CONFIG_ARCH_LPC32XX) += irq-lpc32xx.o