2019-12-25 11:09:25

by Guido Günther

[permalink] [raw]
Subject: [PATCH v2 0/6] leds: lm3692x: Allow to set ovp and brigthness mode

Overvoltage protection and brightness mode are currently hardcoded
as 29V and disabled in the driver. Make these configurable via DT.

Besides addressing review comments v2 also allows to limit the maximum led
current.

Changes from v1
- As per review comments by Dan Murphy
https://lore.kernel.org/linux-leds/[email protected]/
- Split commits per propoerty
- Add new properties to DT example too
- Drop dev_dbg() statements
- ovp: fix 21V value parsing
- ovp: Set correct default value if DT parsing fails
- As per review comments by Pavel Machek
https://lore.kernel.org/linux-leds/20191221191515.GF32732@amd/
- Fix defaults (which is 29V)
- Use uV as Unit for ovp property
- Change property name to 'ti,ovp-microvolt' to make it shorter
- Honor led-max-microamp to not exceed the maximum led current

To: Jacek Anaszewski <[email protected]>,Pavel Machek <[email protected]>,Dan Murphy <[email protected]>,Rob Herring <[email protected]>,Mark Rutland <[email protected]>,[email protected],[email protected],[email protected]


Guido Günther (6):
dt: bindings: lm3692x: Add ti,ovp-microvolt property
leds: lm3692x: Allow to configure over voltage protection
dt: bindings: lm3692x: Add ti,brightness-mapping-exponential property
leds: lm3692x: Allow to configure brigthness mode
dt: bindings: lm3692x: Add led-max-microamp property
leds: lm3692x: Make sure we don't exceed the maximum led current

.../devicetree/bindings/leds/leds-lm3692x.txt | 11 +++
drivers/leds/leds-lm3692x.c | 67 +++++++++++++++++--
2 files changed, 72 insertions(+), 6 deletions(-)

--
2.23.0


2019-12-25 11:11:10

by Guido Günther

[permalink] [raw]
Subject: [PATCH v2 5/6] dt: bindings: lm3692x: Add led-max-microamp property

This can be used to limit the current per led strip

Signed-off-by: Guido Günther <[email protected]>
---
Documentation/devicetree/bindings/leds/leds-lm3692x.txt | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
index 73f41249ecd3..e0d7b3030c01 100644
--- a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
+++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
@@ -37,6 +37,8 @@ Optional child properties:
- label : see Documentation/devicetree/bindings/leds/common.txt (deprecated)
- linux,default-trigger :
see Documentation/devicetree/bindings/leds/common.txt
+ - led-max-microamp :
+ see Documentation/devicetree/bindings/leds/common.txt

Example:

@@ -58,6 +60,7 @@ led-controller@36 {
function = LED_FUNCTION_BACKLIGHT;
color = <LED_COLOR_ID_WHITE>;
linux,default-trigger = "backlight";
+ led-max-microamp = <20000>;
};
}

--
2.23.0

2019-12-26 10:10:39

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH v2 5/6] dt: bindings: lm3692x: Add led-max-microamp property

On Wed 2019-12-25 12:07:18, Guido G?nther wrote:
> This can be used to limit the current per led strip

"per LED strip."

Acked-by: Pavel Machek <[email protected]>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


Attachments:
(No filename) (307.00 B)
signature.asc (188.00 B)
Digital signature
Download all attachments