2019-12-26 19:19:58

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt: bindings: lm3692x: Document new properties

On Mon, Dec 16, 2019 at 01:28:05PM +0100, Guido G?nther wrote:
> We allow configuration of brightness mode and over voltage
> protection.
>
> Signed-off-by: Guido G?nther <[email protected]>
> ---
> Documentation/devicetree/bindings/leds/leds-lm3692x.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
> index 4c2d923f8758..f195e8b45d85 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
> @@ -18,6 +18,10 @@ Required properties:
> Optional properties:
> - enable-gpios : gpio pin to enable/disable the device.
> - vled-supply : LED supply
> + - ti,brightness-mapping-exponential: Whether to use exponential
> + brightness mapping
> + - ti,overvoltage-volts: Overvoltage protection in Volts, can
> + be 0 (unprotected), 21, 25 or 29V

'-microvolt' is the standard unit suffix.

>
> Required child properties:
> - reg : 0 - Will enable all LED sync paths
> --
> 2.23.0
>


2019-12-27 10:17:24

by Guido Günther

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt: bindings: lm3692x: Document new properties

Hi,
On Thu, Dec 26, 2019 at 12:19:06PM -0700, Rob Herring wrote:
> On Mon, Dec 16, 2019 at 01:28:05PM +0100, Guido G?nther wrote:
> > We allow configuration of brightness mode and over voltage
> > protection.
> >
> > Signed-off-by: Guido G?nther <[email protected]>
> > ---
> > Documentation/devicetree/bindings/leds/leds-lm3692x.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
> > index 4c2d923f8758..f195e8b45d85 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
> > +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
> > @@ -18,6 +18,10 @@ Required properties:
> > Optional properties:
> > - enable-gpios : gpio pin to enable/disable the device.
> > - vled-supply : LED supply
> > + - ti,brightness-mapping-exponential: Whether to use exponential
> > + brightness mapping
> > + - ti,overvoltage-volts: Overvoltage protection in Volts, can
> > + be 0 (unprotected), 21, 25 or 29V
>
> '-microvolt' is the standard unit suffix.

Fixed in v2:

https://lore.kernel.org/linux-leds/20191226100615.GA4033@amd/T/#u

Cheers,
-- Guido

>
> >
> > Required child properties:
> > - reg : 0 - Will enable all LED sync paths
> > --
> > 2.23.0
> >
>