2019-12-28 07:17:08

by Nishad Kamdar

Subject: [PATCH] siox: Use the correct style for SPDX License Identifier

This patch corrects the SPDX License Identifier style in
header file related to Ecklemann SIOX driver.
For C header files Documentation/process/license-rules.rst
mandates C-like comments (opposed to C source files where
C++ style should be used).

Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.

Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Nishad Kamdar <[email protected]>
---
drivers/siox/siox.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/siox/siox.h b/drivers/siox/siox.h
index c674bf6fb119..f08b43b713c5 100644
--- a/drivers/siox/siox.h
+++ b/drivers/siox/siox.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Copyright (C) 2015-2017 Pengutronix, Uwe Kleine-König <[email protected]>
*/
--
2.17.1

2019-12-30 12:54:11

by Uwe Kleine-König

Subject: Re: [PATCH] siox: Use the correct style for SPDX License Identifier

On Sat, Dec 28, 2019 at 12:45:48PM +0530, Nishad Kamdar wrote:
> This patch corrects the SPDX License Identifier style in
> header file related to Ecklemann SIOX driver.

s/Ecklemann/Eckelmann/

> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used).
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.

Other than that, I assume this is fine. So if you fix the name above,
you can add my Acked-by:.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |

2020-01-01 13:19:19

by Nishad Kamdar

Subject: Re: [PATCH] siox: Use the correct style for SPDX License Identifier

On Mon, Dec 30, 2019 at 01:52:32PM +0100, Uwe Kleine-König wrote:
> On Sat, Dec 28, 2019 at 12:45:48PM +0530, Nishad Kamdar wrote:
> > This patch corrects the SPDX License Identifier style in
> > header file related to Ecklemann SIOX driver.
>
> s/Ecklemann/Eckelmann/
>
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used).
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
>
> Other than that, I assume this is fine. So if you fix the name above,
> you can add my Acked-by:.
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |

Ok, I'll do that.

Thank you very much for the review.

Regards,
Nishad