2020-01-01 13:15:38

by Nishad Kamdar

[permalink] [raw]
Subject: [PATCH v2] siox: Use the correct style for SPDX License Identifier

This patch corrects the SPDX License Identifier style in
header file related to Eckelmann SIOX driver.
For C header files Documentation/process/license-rules.rst
mandates C-like comments (opposed to C source files where
C++ style should be used).

Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.

Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Nishad Kamdar <[email protected]>
Acked-by: Uwe Kleine-König <[email protected]>
---
Changes in v2:
- Correct the spelling of the word Eckelmann.
---
drivers/siox/siox.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/siox/siox.h b/drivers/siox/siox.h
index c674bf6fb119..f08b43b713c5 100644
--- a/drivers/siox/siox.h
+++ b/drivers/siox/siox.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Copyright (C) 2015-2017 Pengutronix, Uwe Kleine-König <[email protected]>
*/
--
2.17.1


2020-01-07 06:48:54

by Thorsten Scherer

[permalink] [raw]
Subject: Re: [PATCH v2] siox: Use the correct style for SPDX License Identifier

On Wed, Jan 01, 2020 at 06:44:23PM +0530, Nishad Kamdar wrote:
> This patch corrects the SPDX License Identifier style in
> header file related to Eckelmann SIOX driver.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used).
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Nishad Kamdar <[email protected]>
> Acked-by: Uwe Kleine-K?nig <[email protected]>

Acked-by: Thorsten Scherer <[email protected]>

> ---
> Changes in v2:
> - Correct the spelling of the word Eckelmann.
> ---
> drivers/siox/siox.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/siox/siox.h b/drivers/siox/siox.h
> index c674bf6fb119..f08b43b713c5 100644
> --- a/drivers/siox/siox.h
> +++ b/drivers/siox/siox.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * Copyright (C) 2015-2017 Pengutronix, Uwe Kleine-K?nig <[email protected]>
> */
> --
> 2.17.1
>

Kind regards
Thorsten

--
Thorsten Scherer | Eckelmann AG | http://www.eckelmann.de |

2020-01-07 07:34:13

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH v2] siox: Use the correct style for SPDX License Identifier

Hello,

On Tue, Jan 07, 2020 at 07:32:50AM +0100, Thorsten Scherer wrote:
> On Wed, Jan 01, 2020 at 06:44:23PM +0530, Nishad Kamdar wrote:
> > This patch corrects the SPDX License Identifier style in
> > header file related to Eckelmann SIOX driver.
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used).
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
> >
> > Suggested-by: Joe Perches <[email protected]>
> > Signed-off-by: Nishad Kamdar <[email protected]>
> > Acked-by: Uwe Kleine-K?nig <[email protected]>
>
> Acked-by: Thorsten Scherer <[email protected]>

Acked-by: Uwe Kleine-K?nig <[email protected]>

Greg, do you care for application of this patch?

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |

2020-01-14 20:48:54

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH v2] siox: Use the correct style for SPDX License Identifier

On Tue, Jan 07, 2020 at 08:32:04AM +0100, Uwe Kleine-K?nig wrote:
> Hello,
>
> On Tue, Jan 07, 2020 at 07:32:50AM +0100, Thorsten Scherer wrote:
> > On Wed, Jan 01, 2020 at 06:44:23PM +0530, Nishad Kamdar wrote:
> > > This patch corrects the SPDX License Identifier style in
> > > header file related to Eckelmann SIOX driver.
> > > For C header files Documentation/process/license-rules.rst
> > > mandates C-like comments (opposed to C source files where
> > > C++ style should be used).
> > >
> > > Changes made by using a script provided by Joe Perches here:
> > > https://lkml.org/lkml/2019/2/7/46.
> > >
> > > Suggested-by: Joe Perches <[email protected]>
> > > Signed-off-by: Nishad Kamdar <[email protected]>
> > > Acked-by: Uwe Kleine-K?nig <[email protected]>
> >
> > Acked-by: Thorsten Scherer <[email protected]>
>
> Acked-by: Uwe Kleine-K?nig <[email protected]>

Ah, this is why I had 2 acks, you acked it twice :)

2020-01-14 20:50:33

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH v2] siox: Use the correct style for SPDX License Identifier

On Tue, Jan 14, 2020 at 09:47:34PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 07, 2020 at 08:32:04AM +0100, Uwe Kleine-K?nig wrote:
> > Hello,
> >
> > On Tue, Jan 07, 2020 at 07:32:50AM +0100, Thorsten Scherer wrote:
> > > On Wed, Jan 01, 2020 at 06:44:23PM +0530, Nishad Kamdar wrote:
> > > > This patch corrects the SPDX License Identifier style in
> > > > header file related to Eckelmann SIOX driver.
> > > > For C header files Documentation/process/license-rules.rst
> > > > mandates C-like comments (opposed to C source files where
> > > > C++ style should be used).
> > > >
> > > > Changes made by using a script provided by Joe Perches here:
> > > > https://lkml.org/lkml/2019/2/7/46.
> > > >
> > > > Suggested-by: Joe Perches <[email protected]>
> > > > Signed-off-by: Nishad Kamdar <[email protected]>
> > > > Acked-by: Uwe Kleine-K?nig <[email protected]>
> > >
> > > Acked-by: Thorsten Scherer <[email protected]>
> >
> > Acked-by: Uwe Kleine-K?nig <[email protected]>
>
> Ah, this is why I had 2 acks, you acked it twice :)

Ah, didn't even notice that v2 came with my ack already.

..ooOO(Acked-intensively-by: ...)

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |