2020-01-05 15:09:05

by Tomer Tayar

Subject: [PATCH] habanalabs: Modify CS jobs counter to u16

As HL_MAX_JOBS_PER_CS is 512, it is possible that more than 255 CS jobs
will be submitted for a certain queue. Hence, modify the
"jobs_in_queue_cnt" parameter of the "hl_cs" structure to be u16 instead
of u8.

Signed-off-by: Tomer Tayar <[email protected]>
---
drivers/misc/habanalabs/habanalabs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/habanalabs/habanalabs.h b/drivers/misc/habanalabs/habanalabs.h
index df34227dea31..77fe4315dbee 100644
--- a/drivers/misc/habanalabs/habanalabs.h
+++ b/drivers/misc/habanalabs/habanalabs.h
@@ -763,7 +763,7 @@ struct hl_userptr {
* @aborted: true if CS was aborted due to some device error.
*/
struct hl_cs {
- u8 jobs_in_queue_cnt[HL_MAX_QUEUES];
+ u16 jobs_in_queue_cnt[HL_MAX_QUEUES];
struct hl_ctx *ctx;
struct list_head job_list;
spinlock_t job_lock;
--
2.17.1

2020-01-06 05:55:13

by Oded Gabbay

Subject: Re: [PATCH] habanalabs: Modify CS jobs counter to u16

On Sun, Jan 5, 2020 at 5:05 PM Tomer Tayar <[email protected]> wrote:
>
> As HL_MAX_JOBS_PER_CS is 512, it is possible that more than 255 CS jobs
> will be submitted for a certain queue. Hence, modify the
> "jobs_in_queue_cnt" parameter of the "hl_cs" structure to be u16 instead
> of u8.
>
> Signed-off-by: Tomer Tayar <[email protected]>
> ---
> drivers/misc/habanalabs/habanalabs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/habanalabs.h b/drivers/misc/habanalabs/habanalabs.h
> index df34227dea31..77fe4315dbee 100644
> --- a/drivers/misc/habanalabs/habanalabs.h
> +++ b/drivers/misc/habanalabs/habanalabs.h
> @@ -763,7 +763,7 @@ struct hl_userptr {
> * @aborted: true if CS was aborted due to some device error.
> */
> struct hl_cs {
> - u8 jobs_in_queue_cnt[HL_MAX_QUEUES];
> + u16 jobs_in_queue_cnt[HL_MAX_QUEUES];
> struct hl_ctx *ctx;
> struct list_head job_list;
> spinlock_t job_lock;
> --
> 2.17.1
>

This patch is:
Reviewed-by: Oded Gabbay <[email protected]>
Applied to -next
Thanks,
Oded