2020-01-04 14:32:40

by Krzysztof Kozlowski

Subject: [PATCH] net: wan: sdla: Fix cast from pointer to integer of different size

Since net_device.mem_start is unsigned long, it should not be cast to
int right before casting to pointer. This fixes warning (compile
testing on alpha architecture):

drivers/net/wan/sdla.c: In function ‘sdla_transmit’:
drivers/net/wan/sdla.c:711:13: warning:
cast to pointer from integer of different size [-Wint-to-pointer-cast]

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Only compile tested
---
drivers/net/wan/sdla.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/sdla.c b/drivers/net/wan/sdla.c
index e2e679a01b65..77ccf3672ede 100644
--- a/drivers/net/wan/sdla.c
+++ b/drivers/net/wan/sdla.c
@@ -708,7 +708,7 @@ static netdev_tx_t sdla_transmit(struct sk_buff *skb,

spin_lock_irqsave(&sdla_lock, flags);
SDLA_WINDOW(dev, addr);
- pbuf = (void *)(((int) dev->mem_start) + (addr & SDLA_ADDR_MASK));
+ pbuf = (void *)(dev->mem_start + (addr & SDLA_ADDR_MASK));
__sdla_write(dev, pbuf->buf_addr, skb->data, skb->len);
SDLA_WINDOW(dev, addr);
pbuf->opp_flag = 1;
--
2.17.1

2020-01-06 21:31:23

by David Miller

Subject: Re: [PATCH] net: wan: sdla: Fix cast from pointer to integer of different size

From: Krzysztof Kozlowski <[email protected]>
Date: Sat, 4 Jan 2020 15:31:43 +0100

> Since net_device.mem_start is unsigned long, it should not be cast to
> int right before casting to pointer. This fixes warning (compile
> testing on alpha architecture):
>
> drivers/net/wan/sdla.c: In function ?sdla_transmit?:
> drivers/net/wan/sdla.c:711:13: warning:
> cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Applied.