2020-01-07 15:04:30

by Dejin Zheng

Subject: [PATCH] Documentation: networking: device drivers: sync stmmac_mdio_bus_data info

Recent changes in the stmmac driver, it removes the phy_reset hook
from struct stmmac_mdio_bus_data by commit <fead5b1b5838ba2>, and
add the member of needs_reset to struct stmmac_mdio_bus_data by
commit <1a981c0586c0387>.

Signed-off-by: Dejin Zheng <[email protected]>
---
Documentation/networking/device_drivers/stmicro/stmmac.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/networking/device_drivers/stmicro/stmmac.txt b/Documentation/networking/device_drivers/stmicro/stmmac.txt
index 1ae979fd90d2..3d8a83158309 100644
--- a/Documentation/networking/device_drivers/stmicro/stmmac.txt
+++ b/Documentation/networking/device_drivers/stmicro/stmmac.txt
@@ -190,17 +190,17 @@ Where:
For MDIO bus The we have:

struct stmmac_mdio_bus_data {
- int (*phy_reset)(void *priv);
unsigned int phy_mask;
int *irqs;
int probed_phy_irq;
+ bool needs_reset;
};

Where:
- o phy_reset: hook to reset the phy device attached to the bus.
o phy_mask: phy mask passed when register the MDIO bus within the driver.
o irqs: list of IRQs, one per PHY.
o probed_phy_irq: if irqs is NULL, use this for probed PHY.
+ o needs_reset: make MDIO bus reset optional.

For DMA engine we have the following internal fields that should be
tuned according to the HW capabilities.
--
2.17.1

2020-01-07 15:17:56

by Jose Abreu

Subject: RE: [PATCH] Documentation: networking: device drivers: sync stmmac_mdio_bus_data info

From: Dejin Zheng <[email protected]>
Date: Jan/07/2020, 15:02:54 (UTC+00:00)

> Recent changes in the stmmac driver, it removes the phy_reset hook
> from struct stmmac_mdio_bus_data by commit <fead5b1b5838ba2>, and
> add the member of needs_reset to struct stmmac_mdio_bus_data by
> commit <1a981c0586c0387>.

This will file be no longer maitained as we are moving to RST format.
Please see [1].

[1] https://patchwork.ozlabs.org/project/netdev/list/?series=151601

---
Thanks,
Jose Miguel Abreu

2020-01-07 15:43:34

by Dejin Zheng

Subject: Re: [PATCH] Documentation: networking: device drivers: sync stmmac_mdio_bus_data info

On Tue, Jan 07, 2020 at 03:16:10PM +0000, Jose Abreu wrote:
> From: Dejin Zheng <[email protected]>
> Date: Jan/07/2020, 15:02:54 (UTC+00:00)
>
> > Recent changes in the stmmac driver, it removes the phy_reset hook
> > from struct stmmac_mdio_bus_data by commit <fead5b1b5838ba2>, and
> > add the member of needs_reset to struct stmmac_mdio_bus_data by
> > commit <1a981c0586c0387>.
>
> This will file be no longer maitained as we are moving to RST format.
> Please see [1].
>
> [1] https://patchwork.ozlabs.org/project/netdev/list/?series=151601
>
Jose, Thanks for your notice, abandon this commit.

BR,
dejin

> ---
> Thanks,
> Jose Miguel Abreu