2019-11-13 09:24:58

by Peter Ujfalusi

[permalink] [raw]
Subject: [PATCH] iio: buffer-dmaengine: Use dma_request_chan() directly for channel request

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <[email protected]>
---
drivers/iio/buffer/industrialio-buffer-dmaengine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
index bea4a75e92f1..b7b5a934e9b2 100644
--- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c
+++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
@@ -150,7 +150,7 @@ struct iio_buffer *iio_dmaengine_buffer_alloc(struct device *dev,
if (!dmaengine_buffer)
return ERR_PTR(-ENOMEM);

- chan = dma_request_slave_channel_reason(dev, channel);
+ chan = dma_request_chan(dev, channel);
if (IS_ERR(chan)) {
ret = PTR_ERR(chan);
goto err_free;
--
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


2019-11-14 04:35:06

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] iio: buffer-dmaengine: Use dma_request_chan() directly for channel request

On 13-11-19, 11:24, Peter Ujfalusi wrote:
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
> dma_request_chan(dev, name)

Reviewed-by: Vinod Koul <[email protected]>

--
~Vinod

2019-11-16 16:28:02

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] iio: buffer-dmaengine: Use dma_request_chan() directly for channel request

On Thu, 14 Nov 2019 10:03:18 +0530
Vinod Koul <[email protected]> wrote:

> On 13-11-19, 11:24, Peter Ujfalusi wrote:
> > dma_request_slave_channel_reason() is:
> > #define dma_request_slave_channel_reason(dev, name) \
> > dma_request_chan(dev, name)
>
> Reviewed-by: Vinod Koul <[email protected]>
>

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

2020-01-07 12:20:47

by Peter Ujfalusi

[permalink] [raw]
Subject: Re: [PATCH] iio: buffer-dmaengine: Use dma_request_chan() directly for channel request

Jonathan,

On 16/11/2019 18.22, Jonathan Cameron wrote:
> On Thu, 14 Nov 2019 10:03:18 +0530
> Vinod Koul <[email protected]> wrote:
>
>> On 13-11-19, 11:24, Peter Ujfalusi wrote:
>>> dma_request_slave_channel_reason() is:
>>> #define dma_request_slave_channel_reason(dev, name) \
>>> dma_request_chan(dev, name)
>>
>> Reviewed-by: Vinod Koul <[email protected]>
>>
>
> Applied to the togreg branch of iio.git and pushed out as testing
> for the autobuilders to play with it.

The sole user in mainline for dma_request_slave_channel_reason() is
industrialio-buffer-dmaengine.c (since v5.5-rc1, 5.4 had 36 users).

Are you planning to queue this patch for 5.6 (not sure if it could be
sent to -rc6) so I can retire it from the dmaengine.h?

Regards,
- Péter

>
> Thanks,
>
> Jonathan
>

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2020-01-08 15:45:21

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] iio: buffer-dmaengine: Use dma_request_chan() directly for channel request

On Tue, 7 Jan 2020 14:19:43 +0200
Peter Ujfalusi <[email protected]> wrote:

> Jonathan,
>
> On 16/11/2019 18.22, Jonathan Cameron wrote:
> > On Thu, 14 Nov 2019 10:03:18 +0530
> > Vinod Koul <[email protected]> wrote:
> >
> >> On 13-11-19, 11:24, Peter Ujfalusi wrote:
> >>> dma_request_slave_channel_reason() is:
> >>> #define dma_request_slave_channel_reason(dev, name) \
> >>> dma_request_chan(dev, name)
> >>
> >> Reviewed-by: Vinod Koul <[email protected]>
> >>
> >
> > Applied to the togreg branch of iio.git and pushed out as testing
> > for the autobuilders to play with it.
>
> The sole user in mainline for dma_request_slave_channel_reason() is
> industrialio-buffer-dmaengine.c (since v5.5-rc1, 5.4 had 36 users).
>
> Are you planning to queue this patch for 5.6 (not sure if it could be
> sent to -rc6) so I can retire it from the dmaengine.h?

It's queued up for the 5.6 merge window.

Jonathan

>
> Regards,
> - P?ter
>
> >
> > Thanks,
> >
> > Jonathan
> >
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki