2020-01-07 09:31:13

by Khouloud Touil

[permalink] [raw]
Subject: [PATCH v4 4/5] dt-bindings: at25: add reference for the wp-gpios property

As the at25 uses the NVMEM subsystem, and the property is now being
handled, adding reference for it in the device tree binding document,
which allows to specify the GPIO line to which the write-protect pin
is connected.

Signed-off-by: Khouloud Touil <[email protected]>
---
Documentation/devicetree/bindings/eeprom/at25.txt | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/eeprom/at25.txt b/Documentation/devicetree/bindings/eeprom/at25.txt
index 42577dd113dd..fcacd97abd0a 100644
--- a/Documentation/devicetree/bindings/eeprom/at25.txt
+++ b/Documentation/devicetree/bindings/eeprom/at25.txt
@@ -20,6 +20,7 @@ Optional properties:
- spi-cpha : SPI shifted clock phase, as per spi-bus bindings.
- spi-cpol : SPI inverse clock polarity, as per spi-bus bindings.
- read-only : this parameter-less property disables writes to the eeprom
+- wp-gpios : GPIO to which the write-protect pin of the chip is connected

Obsolete legacy properties can be used in place of "size", "pagesize",
"address-width", and "read-only":
@@ -36,6 +37,7 @@ Example:
spi-max-frequency = <5000000>;
spi-cpha;
spi-cpol;
+ wp-gpios = <&gpio1 3 0>;

pagesize = <64>;
size = <32768>;
--
2.17.1


2020-01-08 20:55:58

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v4 4/5] dt-bindings: at25: add reference for the wp-gpios property

On Tue, 7 Jan 2020 10:29:21 +0100, Khouloud Touil wrote:
> As the at25 uses the NVMEM subsystem, and the property is now being
> handled, adding reference for it in the device tree binding document,
> which allows to specify the GPIO line to which the write-protect pin
> is connected.
>
> Signed-off-by: Khouloud Touil <[email protected]>
> ---
> Documentation/devicetree/bindings/eeprom/at25.txt | 2 ++
> 1 file changed, 2 insertions(+)
>

Reviewed-by: Rob Herring <[email protected]>

2020-01-09 09:50:27

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH v4 4/5] dt-bindings: at25: add reference for the wp-gpios property

śr., 8 sty 2020 o 21:54 Rob Herring <[email protected]> napisał(a):
>
> On Tue, 7 Jan 2020 10:29:21 +0100, Khouloud Touil wrote:
> > As the at25 uses the NVMEM subsystem, and the property is now being
> > handled, adding reference for it in the device tree binding document,
> > which allows to specify the GPIO line to which the write-protect pin
> > is connected.
> >
> > Signed-off-by: Khouloud Touil <[email protected]>
> > ---
> > Documentation/devicetree/bindings/eeprom/at25.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
>
> Reviewed-by: Rob Herring <[email protected]>

Hi Greg,

AT25 patches usually go through the char-misc tree. In this case
however, the change depends on the other patches in this series. Can
you ack this and I'll take it through the AT24 tree exceptionally?

Best regards,
Bartosz Golaszewski

2020-01-14 14:44:31

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v4 4/5] dt-bindings: at25: add reference for the wp-gpios property

On Thu, Jan 09, 2020 at 10:47:56AM +0100, Bartosz Golaszewski wrote:
> śr., 8 sty 2020 o 21:54 Rob Herring <[email protected]> napisał(a):
> >
> > On Tue, 7 Jan 2020 10:29:21 +0100, Khouloud Touil wrote:
> > > As the at25 uses the NVMEM subsystem, and the property is now being
> > > handled, adding reference for it in the device tree binding document,
> > > which allows to specify the GPIO line to which the write-protect pin
> > > is connected.
> > >
> > > Signed-off-by: Khouloud Touil <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/eeprom/at25.txt | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> >
> > Reviewed-by: Rob Herring <[email protected]>
>
> Hi Greg,
>
> AT25 patches usually go through the char-misc tree. In this case
> however, the change depends on the other patches in this series. Can
> you ack this and I'll take it through the AT24 tree exceptionally?

Acked-by: Greg Kroah-Hartman <[email protected]>

2020-01-14 15:08:58

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH v4 4/5] dt-bindings: at25: add reference for the wp-gpios property

wt., 14 sty 2020 o 15:42 Greg KH <[email protected]> napisał(a):
>
> On Thu, Jan 09, 2020 at 10:47:56AM +0100, Bartosz Golaszewski wrote:
> > śr., 8 sty 2020 o 21:54 Rob Herring <[email protected]> napisał(a):
> > >
> > > On Tue, 7 Jan 2020 10:29:21 +0100, Khouloud Touil wrote:
> > > > As the at25 uses the NVMEM subsystem, and the property is now being
> > > > handled, adding reference for it in the device tree binding document,
> > > > which allows to specify the GPIO line to which the write-protect pin
> > > > is connected.
> > > >
> > > > Signed-off-by: Khouloud Touil <[email protected]>
> > > > ---
> > > > Documentation/devicetree/bindings/eeprom/at25.txt | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > >
> > > Reviewed-by: Rob Herring <[email protected]>
> >
> > Hi Greg,
> >
> > AT25 patches usually go through the char-misc tree. In this case
> > however, the change depends on the other patches in this series. Can
> > you ack this and I'll take it through the AT24 tree exceptionally?
>
> Acked-by: Greg Kroah-Hartman <[email protected]>

Patch applied with Greg's Ack.

Bart