2020-01-09 11:50:45

by Hsin-Yi Wang

Subject: [PATCH 0/2] Add mt8173 elm and hana board

This series adds devicetree and binding document for Acer Chromebook R13 (elm)
and Lenovo Chromebook (hana), which are using mt8173 as SoC.


Hsin-Yi Wang (2):
dt-bindings: arm64: dts: mediatek: Add mt8173 elm and hana
arm64: dts: mediatek: add mt8173 elm and hana board

.../devicetree/bindings/arm/mediatek.yaml | 18 +
arch/arm64/boot/dts/mediatek/Makefile | 3 +
.../dts/mediatek/mt8173-elm-hana-rev7.dts | 27 +
.../boot/dts/mediatek/mt8173-elm-hana.dts | 16 +
.../boot/dts/mediatek/mt8173-elm-hana.dtsi | 53 +
arch/arm64/boot/dts/mediatek/mt8173-elm.dts | 15 +
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1069 +++++++++++++++++
7 files changed, 1201 insertions(+)
create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi

--
2.25.0.rc1.283.g88dfdc4193-goog

2020-01-09 11:57:33

by Hsin-Yi Wang

Subject: [PATCH 1/2] dt-bindings: arm64: dts: mediatek: Add mt8173 elm and hana

Elm is Acer Chromebook R13. Hana is Lenovo Chromebook. Both uses mt8173
SoC.

Signed-off-by: Hsin-Yi Wang <[email protected]>
---
.../devicetree/bindings/arm/mediatek.yaml | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 4043c5046441..a27b22f264a2 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -86,6 +86,24 @@ properties:
- const: mediatek,mt8135
- items:
- enum:
+ - google,elm
+ - google,elm-rev1
+ - google,elm-rev2
+ - google,elm-rev3
+ - google,elm-rev4
+ - google,elm-rev5
+ - google,elm-rev6
+ - google,elm-rev7
+ - google,elm-rev8
+ - google,hana
+ - google,hana-rev0
+ - google,hana-rev1
+ - google,hana-rev2
+ - google,hana-rev3
+ - google,hana-rev4
+ - google,hana-rev5
+ - google,hana-rev6
+ - google,hana-rev7
- mediatek,mt8173-evb
- const: mediatek,mt8173
- items:
--
2.25.0.rc1.283.g88dfdc4193-goog

2020-01-09 17:22:28

by Enric Balletbo i Serra

Subject: Re: [PATCH 1/2] dt-bindings: arm64: dts: mediatek: Add mt8173 elm and hana

Hi Hsin-Yi,

Thanks for sending this patch upstream, one comment below ...

On 9/1/20 11:10, Hsin-Yi Wang wrote:
> Elm is Acer Chromebook R13. Hana is Lenovo Chromebook. Both uses mt8173
> SoC.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 4043c5046441..a27b22f264a2 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -86,6 +86,24 @@ properties:
> - const: mediatek,mt8135
> - items:
> - enum:
> + - google,elm
> + - google,elm-rev1
> + - google,elm-rev2
> + - google,elm-rev3
> + - google,elm-rev4
> + - google,elm-rev5
> + - google,elm-rev6
> + - google,elm-rev7
> + - google,elm-rev8

Did you run dtbs_check [1] after having patch 2 applied? I think that will
trigger some errors. I am not sure if this should be a const instead of an enum
like we have in rockchip.yaml?

[1] make ARCH=arm64
DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/mediatek.yaml dtbs_check

Thanks,
Enric

> + - google,hana
> + - google,hana-rev0
> + - google,hana-rev1
> + - google,hana-rev2
> + - google,hana-rev3
> + - google,hana-rev4
> + - google,hana-rev5
> + - google,hana-rev6
> + - google,hana-rev7
> - mediatek,mt8173-evb
> - const: mediatek,mt8173
> - items:
>