In the variant RC5T619 the mfd has an RTC. This patchset adds
support for it. To do so it adds the missing register defines in
rn5t618.h and general irq handling for that.
It seems that the irq definitions are the same except missing RTC
but due to missing ability to test that I do not add them here.
The rtc driver itself is based on
https://github.com/kobolabs/Kobo-Reader/blob/master/hw/imx6sll-clara/kernel.tar.bz2
but heavily reworked.
It was tested on the Kobo Clara HD.
For cleaning up there is a separate off-topic patch:
mfd: rn5t618: cleanup i2c_device_id
Changes in v5:
- static rn5t618_irq_init
- PLATFORM_DEVID_NONE
- added some Acked-Bys
Changes in v4:
- use macros for IRQ definitions
- merge rn5t618-core.c and rn5t618-irq.c
Changes in v3:
- alignment cleanup
- output cleanup, remove useless toggling of alarm flag in rtc probe
- updated bindings description, so patch 1/5 becomes 2/6 and so on
Changes in v2:
- no dead code in irq code
- various improvements and cleanups in rtc driver itself
Andreas Kemnade (5):
dt-bindings: mfd: rn5t618: Document optional property interrupts
mfd: rn5t618: add IRQ support
mfd: rn5t618: add RTC related registers
mfd: rn5t618: add more subdevices
rtc: rc5t619: add ricoh rc5t619 RTC driver
Documentation/devicetree/bindings/mfd/rn5t618.txt | 4 +
drivers/mfd/Kconfig | 1 +
drivers/mfd/rn5t618.c | 109 +++++-
drivers/rtc/Kconfig | 10 +
drivers/rtc/Makefile | 1 +
drivers/rtc/rtc-rc5t619.c | 444 ++++++++++++++++++++++
include/linux/mfd/rn5t618.h | 26 ++
7 files changed, 593 insertions(+), 2 deletions(-)
create mode 100644 drivers/rtc/rtc-rc5t619.c
--
2.11.0
These chips use interrupts for various things like RTC alarm.
Signed-off-by: Andreas Kemnade <[email protected]>
Acked-for-MFD-by: Lee Jones <[email protected]>
Acked-by: Rob Herring <[email protected]>
---
Changes in v4: add refernce to interrupt binding
documentation
Documentation/devicetree/bindings/mfd/rn5t618.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/rn5t618.txt b/Documentation/devicetree/bindings/mfd/rn5t618.txt
index b74e5e94d1cb..16778ea00dbc 100644
--- a/Documentation/devicetree/bindings/mfd/rn5t618.txt
+++ b/Documentation/devicetree/bindings/mfd/rn5t618.txt
@@ -15,6 +15,8 @@ Required properties:
- reg: the I2C slave address of the device
Optional properties:
+ - interrupts: interrupt mapping for IRQ
+ See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
- system-power-controller:
See Documentation/devicetree/bindings/power/power-controller.txt
@@ -32,6 +34,8 @@ Example:
pmic@32 {
compatible = "ricoh,rn5t618";
reg = <0x32>;
+ interrupt-parent = <&gpio5>;
+ interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
system-power-controller;
regulators {
--
2.11.0
Hi,
I hope everyone went well into new year, are there any open
issues left here preveting applying these patches?
On Fri, 20 Dec 2019 13:24:11 +0100
Andreas Kemnade <[email protected]> wrote:
> In the variant RC5T619 the mfd has an RTC. This patchset adds
> support for it. To do so it adds the missing register defines in
> rn5t618.h and general irq handling for that.
> It seems that the irq definitions are the same except missing RTC
missing words ... for the rn5t618 ...
> but due to missing ability to test that I do not add them here.
>
> The rtc driver itself is based on
> https://github.com/kobolabs/Kobo-Reader/blob/master/hw/imx6sll-clara/kernel.tar.bz2
> but heavily reworked.
>
> It was tested on the Kobo Clara HD.
>
> For cleaning up there is a separate off-topic patch:
> mfd: rn5t618: cleanup i2c_device_id
>
> Changes in v5:
> - static rn5t618_irq_init
> - PLATFORM_DEVID_NONE
> - added some Acked-Bys
>
> Changes in v4:
> - use macros for IRQ definitions
> - merge rn5t618-core.c and rn5t618-irq.c
>
> Changes in v3:
> - alignment cleanup
> - output cleanup, remove useless toggling of alarm flag in rtc probe
> - updated bindings description, so patch 1/5 becomes 2/6 and so on
>
> Changes in v2:
> - no dead code in irq code
> - various improvements and cleanups in rtc driver itself
>
> Andreas Kemnade (5):
> dt-bindings: mfd: rn5t618: Document optional property interrupts
> mfd: rn5t618: add IRQ support
> mfd: rn5t618: add RTC related registers
> mfd: rn5t618: add more subdevices
> rtc: rc5t619: add ricoh rc5t619 RTC driver
>
> Documentation/devicetree/bindings/mfd/rn5t618.txt | 4 +
> drivers/mfd/Kconfig | 1 +
> drivers/mfd/rn5t618.c | 109 +++++-
> drivers/rtc/Kconfig | 10 +
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-rc5t619.c | 444 ++++++++++++++++++++++
> include/linux/mfd/rn5t618.h | 26 ++
> 7 files changed, 593 insertions(+), 2 deletions(-)
> create mode 100644 drivers/rtc/rtc-rc5t619.c
>
> --
> 2.11.0
>
>
Hi,
> Am 20.12.2019 um 13:24 schrieb Andreas Kemnade <[email protected]>:
>
> In the variant RC5T619 the mfd has an RTC. This patchset adds
> support for it. To do so it adds the missing register defines in
> rn5t618.h and general irq handling for that.
> It seems that the irq definitions are the same except missing RTC
> but due to missing ability to test that I do not add them here.
>
> The rtc driver itself is based on
> https://github.com/kobolabs/Kobo-Reader/blob/master/hw/imx6sll-clara/kernel.tar.bz2
> but heavily reworked.
>
> It was tested on the Kobo Clara HD.
>
> For cleaning up there is a separate off-topic patch:
> mfd: rn5t618: cleanup i2c_device_id
>
> Changes in v5:
> - static rn5t618_irq_init
> - PLATFORM_DEVID_NONE
> - added some Acked-Bys
>
> Changes in v4:
> - use macros for IRQ definitions
> - merge rn5t618-core.c and rn5t618-irq.c
>
> Changes in v3:
> - alignment cleanup
> - output cleanup, remove useless toggling of alarm flag in rtc probe
> - updated bindings description, so patch 1/5 becomes 2/6 and so on
>
> Changes in v2:
> - no dead code in irq code
> - various improvements and cleanups in rtc driver itself
>
> Andreas Kemnade (5):
> dt-bindings: mfd: rn5t618: Document optional property interrupts
> mfd: rn5t618: add IRQ support
> mfd: rn5t618: add RTC related registers
> mfd: rn5t618: add more subdevices
> rtc: rc5t619: add ricoh rc5t619 RTC driver
what has happened to this series?
It looks like something got lost so that it has not yet arrived in linux-next.
BR and thanks,
Nikolaus Schaller
>
> Documentation/devicetree/bindings/mfd/rn5t618.txt | 4 +
> drivers/mfd/Kconfig | 1 +
> drivers/mfd/rn5t618.c | 109 +++++-
> drivers/rtc/Kconfig | 10 +
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-rc5t619.c | 444 ++++++++++++++++++++++
> include/linux/mfd/rn5t618.h | 26 ++
> 7 files changed, 593 insertions(+), 2 deletions(-)
> create mode 100644 drivers/rtc/rtc-rc5t619.c
>
> --
> 2.11.0
On Wed, 26 Feb 2020, H. Nikolaus Schaller wrote:
> Hi,
>
> > Am 20.12.2019 um 13:24 schrieb Andreas Kemnade <[email protected]>:
> >
> > In the variant RC5T619 the mfd has an RTC. This patchset adds
> > support for it. To do so it adds the missing register defines in
> > rn5t618.h and general irq handling for that.
> > It seems that the irq definitions are the same except missing RTC
> > but due to missing ability to test that I do not add them here.
> >
> > The rtc driver itself is based on
> > https://github.com/kobolabs/Kobo-Reader/blob/master/hw/imx6sll-clara/kernel.tar.bz2
> > but heavily reworked.
> >
> > It was tested on the Kobo Clara HD.
> >
> > For cleaning up there is a separate off-topic patch:
> > mfd: rn5t618: cleanup i2c_device_id
> >
> > Changes in v5:
> > - static rn5t618_irq_init
> > - PLATFORM_DEVID_NONE
> > - added some Acked-Bys
> >
> > Changes in v4:
> > - use macros for IRQ definitions
> > - merge rn5t618-core.c and rn5t618-irq.c
> >
> > Changes in v3:
> > - alignment cleanup
> > - output cleanup, remove useless toggling of alarm flag in rtc probe
> > - updated bindings description, so patch 1/5 becomes 2/6 and so on
> >
> > Changes in v2:
> > - no dead code in irq code
> > - various improvements and cleanups in rtc driver itself
> >
> > Andreas Kemnade (5):
> > dt-bindings: mfd: rn5t618: Document optional property interrupts
> > mfd: rn5t618: add IRQ support
> > mfd: rn5t618: add RTC related registers
> > mfd: rn5t618: add more subdevices
> > rtc: rc5t619: add ricoh rc5t619 RTC driver
>
> what has happened to this series?
> It looks like something got lost so that it has not yet arrived in linux-next.
It won't show up in -next until it's been reviewed/applied.
If it's not been touched for a few weeks/months, assume it's slipped
through the gaps, collect all of the *-bys and submit a [RESEND].
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog