2020-01-11 12:15:38

by Namjae Jeon

Subject: [PATCH] staging: exfat: make staging/exfat and fs/exfat mutually exclusive

From: Namjae Jeon <[email protected]>

Make staging/exfat and fs/exfat mutually exclusive to select the one
between two same filesystem.

Suggested-by: Amir Goldstein <[email protected]>
Signed-off-by: Namjae Jeon <[email protected]>
---
drivers/staging/exfat/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/exfat/Kconfig b/drivers/staging/exfat/Kconfig
index 292a19dfcaf5..9a0fccec65d9 100644
--- a/drivers/staging/exfat/Kconfig
+++ b/drivers/staging/exfat/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
config STAGING_EXFAT_FS
tristate "exFAT fs support"
- depends on BLOCK
+ depends on BLOCK && !EXFAT_FS
select NLS
help
This adds support for the exFAT file system.
--
2.17.1

2020-01-11 17:59:05

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: exfat: make staging/exfat and fs/exfat mutually exclusive

On Sat, Jan 11, 2020 at 09:14:19PM +0900, Namjae Jeon wrote:
> From: Namjae Jeon <[email protected]>
>
> Make staging/exfat and fs/exfat mutually exclusive to select the one
> between two same filesystem.
>
> Suggested-by: Amir Goldstein <[email protected]>
> Signed-off-by: Namjae Jeon <[email protected]>
> ---
> drivers/staging/exfat/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/exfat/Kconfig b/drivers/staging/exfat/Kconfig
> index 292a19dfcaf5..9a0fccec65d9 100644
> --- a/drivers/staging/exfat/Kconfig
> +++ b/drivers/staging/exfat/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0
> config STAGING_EXFAT_FS
> tristate "exFAT fs support"
> - depends on BLOCK
> + depends on BLOCK && !EXFAT_FS

There is no such symbol in the kernel tree, so this isn't going to do
anything :(

When/if EXFAT_FS does show up, I will be glad to add this. Or better
yet, just have this as part of the "real" exfat patchset, that would
make the most sense, right?

thanks,

greg k-h

2020-01-11 23:37:37

by Namjae Jeon

Subject: Re: [PATCH] staging: exfat: make staging/exfat and fs/exfat mutually exclusive

2020-01-12 2:56 GMT+09:00, Greg KH <[email protected]>:
> On Sat, Jan 11, 2020 at 09:14:19PM +0900, Namjae Jeon wrote:
>> From: Namjae Jeon <[email protected]>
>>
>> Make staging/exfat and fs/exfat mutually exclusive to select the one
>> between two same filesystem.
>>
>> Suggested-by: Amir Goldstein <[email protected]>
>> Signed-off-by: Namjae Jeon <[email protected]>
>> ---
>> drivers/staging/exfat/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/exfat/Kconfig
>> b/drivers/staging/exfat/Kconfig
>> index 292a19dfcaf5..9a0fccec65d9 100644
>> --- a/drivers/staging/exfat/Kconfig
>> +++ b/drivers/staging/exfat/Kconfig
>> @@ -1,7 +1,7 @@
>> # SPDX-License-Identifier: GPL-2.0
>> config STAGING_EXFAT_FS
>> tristate "exFAT fs support"
>> - depends on BLOCK
>> + depends on BLOCK && !EXFAT_FS
>
> There is no such symbol in the kernel tree, so this isn't going to do
> anything :(
>
> When/if EXFAT_FS does show up, I will be glad to add this. Or better
> yet, just have this as part of the "real" exfat patchset, that would
> make the most sense, right?
Right,
Thanks!
>
> thanks,
>
> greg k-h
>