2020-01-12 17:15:23

by Frank Lee

Subject: [PATCH] thermal: sun8i: fix using plain integer as NULL pointer in sun8i_ths_resource_init

To fix:

drivers/thermal/sun8i_thermal.c:341:60: sparse: sparse: Using plain
integer as NULL pointer

Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Yangtao Li <[email protected]>
---
drivers/thermal/sun8i_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
index c5661d7c3e20..4bcde9491edb 100644
--- a/drivers/thermal/sun8i_thermal.c
+++ b/drivers/thermal/sun8i_thermal.c
@@ -338,7 +338,7 @@ static int sun8i_ths_resource_init(struct ths_device *tmdev)
return PTR_ERR(tmdev->regmap);

if (tmdev->chip->has_bus_clk_reset) {
- tmdev->reset = devm_reset_control_get(dev, 0);
+ tmdev->reset = devm_reset_control_get(dev, NULL);
if (IS_ERR(tmdev->reset))
return PTR_ERR(tmdev->reset);

--
2.17.1

2020-01-12 17:51:30

by Daniel Lezcano

Subject: Re: [PATCH] thermal: sun8i: fix using plain integer as NULL pointer in sun8i_ths_resource_init

On 12/01/2020 18:13, Yangtao Li wrote:
> To fix:
>
> drivers/thermal/sun8i_thermal.c:341:60: sparse: sparse: Using plain
> integer as NULL pointer
>
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Yangtao Li <[email protected]>

Applied, thanks

> ---
> drivers/thermal/sun8i_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> index c5661d7c3e20..4bcde9491edb 100644
> --- a/drivers/thermal/sun8i_thermal.c
> +++ b/drivers/thermal/sun8i_thermal.c
> @@ -338,7 +338,7 @@ static int sun8i_ths_resource_init(struct ths_device *tmdev)
> return PTR_ERR(tmdev->regmap);
>
> if (tmdev->chip->has_bus_clk_reset) {
> - tmdev->reset = devm_reset_control_get(dev, 0);
> + tmdev->reset = devm_reset_control_get(dev, NULL);
> if (IS_ERR(tmdev->reset))
> return PTR_ERR(tmdev->reset);
>
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog