2020-01-12 18:10:52

by Frank Lee

Subject: [PATCH] thermal: sun8i: remove unused variable and unneeded macros

The cp_ft_flag variable is not used after initialization, so delete
it. After that, THS_EFUSE_CP_FT_MASK, THS_EFUSE_CP_FT_BIT and
THS_CALIBRATION_IN_FT are not needed, so delete them.

Signed-off-by: Yangtao Li <[email protected]>
---
drivers/thermal/sun8i_thermal.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
index 4bcde9491edb..bd7549f9ecba 100644
--- a/drivers/thermal/sun8i_thermal.c
+++ b/drivers/thermal/sun8i_thermal.c
@@ -54,9 +54,6 @@
#define SUN50I_H6_THS_DATA_IRQ_STS(x) BIT(x)

/* millidegree celsius */
-#define THS_EFUSE_CP_FT_MASK 0x3000
-#define THS_EFUSE_CP_FT_BIT 12
-#define THS_CALIBRATION_IN_FT 1

struct tsensor {
struct ths_device *tmdev;
@@ -88,7 +85,6 @@ struct ths_device {
struct clk *bus_clk;
struct clk *mod_clk;
struct tsensor sensor[MAX_SENSOR_NUM];
- u32 cp_ft_flag;
};

/* Temp Unit: millidegree Celsius */
@@ -244,8 +240,6 @@ static int sun50i_h6_ths_calibrate(struct ths_device *tmdev,
* register values and this will become a calibration offset.
*/
ft_temp = (caldata[0] & FT_TEMP_MASK) * 100;
- tmdev->cp_ft_flag = (caldata[0] & THS_EFUSE_CP_FT_MASK)
- >> THS_EFUSE_CP_FT_BIT;

for (i = 0; i < tmdev->chip->sensor_num; i++) {
int sensor_reg = caldata[i + 1];
--
2.17.1

2020-01-12 18:57:55

by Daniel Lezcano

Subject: Re: [PATCH] thermal: sun8i: remove unused variable and unneeded macros

On 12/01/2020 19:09, Yangtao Li wrote:
> The cp_ft_flag variable is not used after initialization, so delete
> it. After that, THS_EFUSE_CP_FT_MASK, THS_EFUSE_CP_FT_BIT and
> THS_CALIBRATION_IN_FT are not needed, so delete them.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---

Applied, thanks


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog