2020-01-13 13:21:17

by chenzhou

Subject: [PATCH] amd-xgbe: remove unnecessary conversion to bool

The conversion to bool is not needed, remove it.

Signed-off-by: Chen Zhou <[email protected]>
---
drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
index 128cd64..46c3c1c 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
@@ -1227,7 +1227,7 @@ static bool xgbe_phy_sfp_verify_eeprom(u8 cc_in, u8 *buf, unsigned int len)
for (cc = 0; len; buf++, len--)
cc += *buf;

- return (cc == cc_in) ? true : false;
+ return cc == cc_in;
}

static int xgbe_phy_sfp_read_eeprom(struct xgbe_prv_data *pdata)
--
2.7.4

2020-01-14 03:30:57

by Jakub Kicinski

Subject: Re: [PATCH] amd-xgbe: remove unnecessary conversion to bool

On Mon, 13 Jan 2020 21:15:16 +0800, Chen Zhou wrote:
> The conversion to bool is not needed, remove it.
>
> Signed-off-by: Chen Zhou <[email protected]>

Applied to net-next, thanks!