2020-01-13 16:03:40

by Andreas Larsson

Subject: [PATCH] sparc32,leon: Stop adding vendor and device id to prom ambapp path components

These extra fields before the @ are not handled in of_node_name_eq,
making commit b3e46d1a0590500335f0b95e669ad6d84b12b03a break node name
comparisons for ambapp path components, thereby making LEON systems
unable to boot.

As there is no need for the tacked on vendor and device ID fields in the
path component, resolve this situation by removing them.

Signed-off-by: Andreas Larsson <[email protected]>
---
arch/sparc/kernel/prom_32.c | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/arch/sparc/kernel/prom_32.c b/arch/sparc/kernel/prom_32.c
index ec244d1022ce..da8902295c8c 100644
--- a/arch/sparc/kernel/prom_32.c
+++ b/arch/sparc/kernel/prom_32.c
@@ -132,12 +132,13 @@ static void __init ebus_path_component(struct device_node *dp, char *tmp_buf)
regs->which_io, regs->phys_addr);
}

-/* "name:vendor:device@irq,addrlo" */
+/* "name@irq,addrlo" */
static void __init ambapp_path_component(struct device_node *dp, char *tmp_buf)
{
const char *name = of_get_property(dp, "name", NULL);
struct amba_prom_registers *regs;
- unsigned int *intr, *device, *vendor, reg0;
+ unsigned int *intr;
+ unsigned int reg0;
struct property *prop;
int interrupt = 0;

@@ -159,18 +160,7 @@ static void __init ambapp_path_component(struct device_node *dp, char *tmp_buf)
else
intr = prop->value;

- prop = of_find_property(dp, "vendor", NULL);
- if (!prop)
- return;
- vendor = prop->value;
- prop = of_find_property(dp, "device", NULL);
- if (!prop)
- return;
- device = prop->value;
-
- sprintf(tmp_buf, "%s:%d:%d@%x,%x",
- name, *vendor, *device,
- *intr, reg0);
+ sprintf(tmp_buf, "%s@%x,%x", name, *intr, reg0);
}

static void __init __build_path_component(struct device_node *dp, char *tmp_buf)
--
2.17.1

2020-01-21 12:26:59

by David Miller

Subject: Re: [PATCH] sparc32,leon: Stop adding vendor and device id to prom ambapp path components

From: Andreas Larsson <[email protected]>
Date: Mon, 13 Jan 2020 17:01:47 +0100

> These extra fields before the @ are not handled in of_node_name_eq,
> making commit b3e46d1a0590500335f0b95e669ad6d84b12b03a break node name
> comparisons for ambapp path components, thereby making LEON systems
> unable to boot.
>
> As there is no need for the tacked on vendor and device ID fields in the
> path component, resolve this situation by removing them.
>
> Signed-off-by: Andreas Larsson <[email protected]>

Applied, thanks.