2020-01-15 10:30:36

by Zhenzhong Duan

Subject: [PATCH] iommu/vt-d: fix the wrong printing in RHSA parsing

When base address in RHSA structure doesn't match base address in
each DRHD structure, the base address in last DRHD is printed out.

This doesn't make sense when there are multiple DRHD units, fix it
by printing the buggy RHSA's base address.

Signed-off-by: Zhenzhong Duan <[email protected]>
Cc: David Woodhouse <[email protected]>
Cc: Lu Baolu <[email protected]>
Cc: Joerg Roedel <[email protected]>
Cc: [email protected]
---
drivers/iommu/dmar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
index 3acfa6a..78bb03e 100644
--- a/drivers/iommu/dmar.c
+++ b/drivers/iommu/dmar.c
@@ -475,7 +475,7 @@ static int dmar_parse_one_rhsa(struct acpi_dmar_header *header, void *arg)
1, TAINT_FIRMWARE_WORKAROUND,
"Your BIOS is broken; RHSA refers to non-existent DMAR unit at %llx\n"
"BIOS vendor: %s; Ver: %s; Product Version: %s\n",
- drhd->reg_base_addr,
+ rhsa->base_address,
dmi_get_system_info(DMI_BIOS_VENDOR),
dmi_get_system_info(DMI_BIOS_VERSION),
dmi_get_system_info(DMI_PRODUCT_VERSION));
--
1.8.3.1

2020-02-21 00:02:15

by Lu Baolu

Subject: Re: [PATCH] iommu/vt-d: fix the wrong printing in RHSA parsing

Hi,

On 2020/1/15 18:28, Zhenzhong Duan wrote:
> When base address in RHSA structure doesn't match base address in
> each DRHD structure, the base address in last DRHD is printed out.
>
> This doesn't make sense when there are multiple DRHD units, fix it
> by printing the buggy RHSA's base address.
>
> Signed-off-by: Zhenzhong Duan<[email protected]>
> Cc: David Woodhouse<[email protected]>
> Cc: Lu Baolu<[email protected]>
> Cc: Joerg Roedel<[email protected]>
> Cc:[email protected]

Queued for v5.7. Thanks!

Best regards,
baolu