Hi Thomas,
On Thu, Jan 16, 2020 at 08:43:41PM +0100, Thomas Gleixner wrote:
> The confinement of the 32bit specific VDSO functions missed to define
> BUILD_VDSO32 when building a 32bit MIPS kernel:
>
> arch/mips/vdso/vgettimeofday.c: In function ‘__vdso_clock_gettime’:
> arch/mips/vdso/vgettimeofday.c:17:9: error: implicit declaration of function ‘__cvdso_clock_gettime32’
>
> arch/mips/vdso/vgettimeofday.c: In function ‘__vdso_clock_getres’:
> arch/mips/vdso/vgettimeofday.c:39:9: error: implicit declaration of function ‘__cvdso_clock_getres_time32’
>
> Force the define for 32bit builds in the VDSO Makefile.
>
> Fixes: bf279849ad59 ("lib/vdso: Build 32 bit specific functions in the right context")
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Thomas Gleixner <[email protected]>
Presuming you want to take this through timers/core along with the patch
it fixes:
Acked-by: Paul Burton <[email protected]>
Thanks,
Paul
> ---
> arch/mips/vdso/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> --- a/arch/mips/vdso/Makefile
> +++ b/arch/mips/vdso/Makefile
> @@ -18,6 +18,10 @@ ccflags-vdso := \
> $(filter -mno-loongson-%,$(KBUILD_CFLAGS)) \
> -D__VDSO__
>
> +ifndef CONFIG_64BIT
> +ccflags-vdso += -DBUILD_VDSO32
> +endif
> +
> ifdef CONFIG_CC_IS_CLANG
> ccflags-vdso += $(filter --target=%,$(KBUILD_CFLAGS))
> endif