irqtime_account_idle_ticks just add longer call path w/o enough meaning.
We don't bother remove this function to simply code and reduce a
bit object size of kernel.
Signed-off-by: Alex Shi <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Juri Lelli <[email protected]>
Cc: Vincent Guittot <[email protected]>
Cc: Dietmar Eggemann <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Ben Segall <[email protected]>
Cc: Mel Gorman <[email protected]>
Cc: [email protected]
---
kernel/sched/cputime.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
index cff3e656566d..17640d145e44 100644
--- a/kernel/sched/cputime.c
+++ b/kernel/sched/cputime.c
@@ -390,12 +390,7 @@ static void irqtime_account_process_tick(struct task_struct *p, int user_tick,
}
}
-static void irqtime_account_idle_ticks(int ticks)
-{
- irqtime_account_process_tick(current, 0, ticks);
-}
#else /* CONFIG_IRQ_TIME_ACCOUNTING */
-static inline void irqtime_account_idle_ticks(int ticks) { }
static inline void irqtime_account_process_tick(struct task_struct *p, int user_tick,
int nr_ticks) { }
#endif /* CONFIG_IRQ_TIME_ACCOUNTING */
@@ -505,7 +500,7 @@ void account_idle_ticks(unsigned long ticks)
u64 cputime, steal;
if (sched_clock_irqtime) {
- irqtime_account_idle_ticks(ticks);
+ irqtime_account_process_tick(current, 0, ticks);
return;
}
--
1.8.3.1
?? 2020/1/16 ????11:17, Alex Shi д??:
> irqtime_account_idle_ticks just add longer call path w/o enough meaning.
> We don't bother remove this function to simply code and reduce a
> bit object size of kernel.
Sorry, above commit log need to revise as following:
irqtime_account_idle_ticks just add longer call path w/o enough meaning.
We'd better to remove this function to simply code and reduce a bit object
size of kernel.
>
> Signed-off-by: Alex Shi <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Juri Lelli <[email protected]>
> Cc: Vincent Guittot <[email protected]>
> Cc: Dietmar Eggemann <[email protected]>
> Cc: Steven Rostedt <[email protected]>
> Cc: Ben Segall <[email protected]>
> Cc: Mel Gorman <[email protected]>
> Cc: [email protected]
> ---
> kernel/sched/cputime.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
> index cff3e656566d..17640d145e44 100644
> --- a/kernel/sched/cputime.c
> +++ b/kernel/sched/cputime.c
> @@ -390,12 +390,7 @@ static void irqtime_account_process_tick(struct task_struct *p, int user_tick,
> }
> }
>
> -static void irqtime_account_idle_ticks(int ticks)
> -{
> - irqtime_account_process_tick(current, 0, ticks);
> -}
> #else /* CONFIG_IRQ_TIME_ACCOUNTING */
> -static inline void irqtime_account_idle_ticks(int ticks) { }
> static inline void irqtime_account_process_tick(struct task_struct *p, int user_tick,
> int nr_ticks) { }
> #endif /* CONFIG_IRQ_TIME_ACCOUNTING */
> @@ -505,7 +500,7 @@ void account_idle_ticks(unsigned long ticks)
> u64 cputime, steal;
>
> if (sched_clock_irqtime) {
> - irqtime_account_idle_ticks(ticks);
> + irqtime_account_process_tick(current, 0, ticks);
> return;
> }
>
>
On Sat, Jan 18, 2020 at 10:04:12AM +0800, Alex Shi wrote:
>
>
> 在 2020/1/18 上午8:32, Tao Zhou 写道:
> > On Thu, Jan 16, 2020 at 11:44:28AM +0800, Alex Shi wrote:
> >>
> >>
> >> 在 2020/1/16 上午11:17, Alex Shi 写道:
> >>> irqtime_account_idle_ticks just add longer call path w/o enough meaning.
> >>> We don't bother remove this function to simply code and reduce a
> >>> bit object size of kernel.
> >>
> >> Sorry, above commit log need to revise as following:
> >>
> >> irqtime_account_idle_ticks just add longer call path w/o enough meaning.
> >> We'd better to remove this function to simply code and reduce a bit object
> >> size of kernel.
> >
> > Looks good and better to me.
>
> Thanks!
>
> Why not reply to lkml openly? :)
Sorry, I want to.
The mail can not send if dest/cc include '[email protected]'
No VPN from me. I will try another mail address. Any advice?