2020-01-19 13:12:10

by Mateusz Nosek

Subject: [PATCH] arch/x86/mm/mpx.c: Clean up code by removing unnecessary assignment

From: Mateusz Nosek <[email protected]>

Previously variable 'ret' is assigned just before return instruction.
The variable is local so this assignment is useless
and therefore can be removed.

Signed-off-by: Mateusz Nosek <[email protected]>
---
arch/x86/mm/mpx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/x86/mm/mpx.c b/arch/x86/mm/mpx.c
index 895fb7a9294d..30ab444301f5 100644
--- a/arch/x86/mm/mpx.c
+++ b/arch/x86/mm/mpx.c
@@ -827,10 +827,8 @@ static int try_unmap_single_bt(struct mm_struct *mm,
/*
* No bounds table there, so nothing to unmap.
*/
- if (ret == -ENOENT) {
- ret = 0;
+ if (ret == -ENOENT)
return 0;
- }
if (ret)
return ret;
/*
--
2.17.1

2020-01-22 13:12:11

by Borislav Petkov

Subject: Re: [PATCH] arch/x86/mm/mpx.c: Clean up code by removing unnecessary assignment

On Sun, Jan 19, 2020 at 02:09:33PM +0100, [email protected] wrote:
> From: Mateusz Nosek <[email protected]>
>
> Previously variable 'ret' is assigned just before return instruction.
> The variable is local so this assignment is useless
> and therefore can be removed.
>
> Signed-off-by: Mateusz Nosek <[email protected]>
> ---
> arch/x86/mm/mpx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/x86/mm/mpx.c b/arch/x86/mm/mpx.c
> index 895fb7a9294d..30ab444301f5 100644
> --- a/arch/x86/mm/mpx.c
> +++ b/arch/x86/mm/mpx.c
> @@ -827,10 +827,8 @@ static int try_unmap_single_bt(struct mm_struct *mm,
> /*
> * No bounds table there, so nothing to unmap.
> */
> - if (ret == -ENOENT) {
> - ret = 0;
> + if (ret == -ENOENT)
> return 0;
> - }
> if (ret)
> return ret;
> /*
> --

That code is going away so you can ignore it completely.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette