2020-01-20 15:41:56

by Miroslav Benes

Subject: [PATCH] arch/Kconfig: Update HAVE_RELIABLE_STACKTRACE description

save_stack_trace_tsk_reliable() is not the only function providing the
reliable stack traces anymore. Architecture might define ARCH_STACKWALK
which provides a newer stack walking interface and has
arch_stack_walk_reliable() function. Update the description accordingly.

Signed-off-by: Miroslav Benes <[email protected]>
---
arch/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index 48b5e103bdb0..f73dbbcc86fe 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -733,8 +733,9 @@ config HAVE_STACK_VALIDATION
config HAVE_RELIABLE_STACKTRACE
bool
help
- Architecture has a save_stack_trace_tsk_reliable() function which
- only returns a stack trace if it can guarantee the trace is reliable.
+ Architecture has either save_stack_trace_tsk_reliable() or
+ arch_stack_walk_reliable() function which only returns a stack trace
+ if it can guarantee the trace is reliable.

config HAVE_ARCH_HASH
bool
--
2.24.1

2020-01-20 17:34:43

by Josh Poimboeuf

Subject: Re: [PATCH] arch/Kconfig: Update HAVE_RELIABLE_STACKTRACE description

On Mon, Jan 20, 2020 at 04:40:42PM +0100, Miroslav Benes wrote:
> save_stack_trace_tsk_reliable() is not the only function providing the
> reliable stack traces anymore. Architecture might define ARCH_STACKWALK
> which provides a newer stack walking interface and has
> arch_stack_walk_reliable() function. Update the description accordingly.
>
> Signed-off-by: Miroslav Benes <[email protected]>

Acked-by: Josh Poimboeuf <[email protected]>

--
Josh