2020-01-18 15:26:27

by Emmanuel Vadot

[permalink] [raw]
Subject: [PATCH v2] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino

From: Emmanuel Vadot <[email protected]>

Add the regulators for each bank on this boards.
For VCC-PL only add a comment on what regulator is used. We cannot add
the property without causing a circular dependency as the PL pins are
used to talk to the PMIC.

Signed-off-by: Emmanuel Vadot <[email protected]>
---
v2:
- Remove vcc-pl-supply in r_pio as it cause a circular dependency.

.../boot/dts/allwinner/sun50i-a64-olinuxino.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index 01a9a52edae4..7e71b5b12f98 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -163,6 +163,17 @@ &ohci1 {
status = "okay";
};

+&pio {
+ vcc-pa-supply = <&reg_dcdc1>;
+ vcc-pb-supply = <&reg_dcdc1>;
+ vcc-pc-supply = <&reg_dcdc1>;
+ vcc-pd-supply = <&reg_dcdc1>;
+ vcc-pe-supply = <&reg_aldo1>;
+ vcc-pf-supply = <&reg_dcdc1>;
+ vcc-pg-supply = <&reg_dldo4>;
+ vcc-ph-supply = <&reg_dcdc1>;
+};
+
&r_rsb {
status = "okay";

@@ -175,6 +186,12 @@ axp803: pmic@3a3 {
};
};

+/* VCC-PL is powered by aldo2 but we cannot add it as the RSB */
+/* interface used to talk to the PMIC in on the PL pins */
+/* &r_pio { */
+/* vcc-pl-supply = <&reg_aldo2>; */
+/* }; */
+
#include "axp803.dtsi"

&ac_power_supply {
--
2.24.1


2020-01-21 09:12:50

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino

Hi,

On Sat, Jan 18, 2020 at 04:24:59PM +0100, Emmanuel Vadot wrote:
> From: Emmanuel Vadot <[email protected]>
>
> Add the regulators for each bank on this boards.
> For VCC-PL only add a comment on what regulator is used. We cannot add
> the property without causing a circular dependency as the PL pins are
> used to talk to the PMIC.
>
> Signed-off-by: Emmanuel Vadot <[email protected]>

It seems that you sent it twice?

I applied the second. It was not applying properly though, make sure
to base your patches on next.

Maxime

Attachments:
(No filename) (550.00 B)
 signature.asc (235.00 B)
 Download all attachments

2020-01-21 11:16:39

by Emmanuel Vadot

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino

On Tue, 21 Jan 2020 10:10:26 +0100
Maxime Ripard <[email protected]> wrote:

> Hi,
>
> On Sat, Jan 18, 2020 at 04:24:59PM +0100, Emmanuel Vadot wrote:
> > From: Emmanuel Vadot <[email protected]>
> >
> > Add the regulators for each bank on this boards.
> > For VCC-PL only add a comment on what regulator is used. We cannot add
> > the property without causing a circular dependency as the PL pins are
> > used to talk to the PMIC.
> >
> > Signed-off-by: Emmanuel Vadot <[email protected]>
>
> It seems that you sent it twice?

Yes sorry mail server hickups.

> I applied the second. It was not applying properly though, make sure
> to base your patches on next.

Ah right, sorry again, I've used master, will use next the next time.
Thanks.

> Maxime


--
Emmanuel Vadot <[email protected]>