2020-01-21 15:57:25

by Eugeniu Rosca

Subject: [PATCH v2] arm64: kbuild: remove compressed images on 'make ARCH=arm64 (dist)clean'

From: Dirk Behme <[email protected]>

Since v4.3-rc1 commit 0723c05fb75e44 ("arm64: enable more compressed
Image formats"), it is possible to build Image.{bz2,lz4,lzma,lzo}
AArch64 images. However, the commit missed adding support for removing
those images on 'make ARCH=arm64 (dist)clean'.

Fix this by adding them to the target list.
Make sure to match the order of the recipes in the makefile.

Cc: [email protected] # v4.3+
Fixes: 0723c05fb75e44 ("arm64: enable more compressed Image formats")
Signed-off-by: Dirk Behme <[email protected]>
Signed-off-by: Eugeniu Rosca <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>

---
v2:
- Added 'Fixes:', 'Cc: stable' and 'Reviewed-by' tags
---
arch/arm64/boot/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/Makefile b/arch/arm64/boot/Makefile
index 1f012c506434..cd3414898d10 100644
--- a/arch/arm64/boot/Makefile
+++ b/arch/arm64/boot/Makefile
@@ -16,7 +16,7 @@

OBJCOPYFLAGS_Image :=-O binary -R .note -R .note.gnu.build-id -R .comment -S

-targets := Image Image.gz
+targets := Image Image.bz2 Image.gz Image.lz4 Image.lzma Image.lzo

$(obj)/Image: vmlinux FORCE
$(call if_changed,objcopy)
--
2.25.0

2020-01-21 16:29:38

by Will Deacon

Subject: Re: [PATCH v2] arm64: kbuild: remove compressed images on 'make ARCH=arm64 (dist)clean'

On Tue, Jan 21, 2020 at 04:54:39PM +0100, Eugeniu Rosca wrote:
> From: Dirk Behme <[email protected]>
>
> Since v4.3-rc1 commit 0723c05fb75e44 ("arm64: enable more compressed
> Image formats"), it is possible to build Image.{bz2,lz4,lzma,lzo}
> AArch64 images. However, the commit missed adding support for removing
> those images on 'make ARCH=arm64 (dist)clean'.
>
> Fix this by adding them to the target list.
> Make sure to match the order of the recipes in the makefile.
>
> Cc: [email protected] # v4.3+
> Fixes: 0723c05fb75e44 ("arm64: enable more compressed Image formats")
> Signed-off-by: Dirk Behme <[email protected]>
> Signed-off-by: Eugeniu Rosca <[email protected]>
> Reviewed-by: Masahiro Yamada <[email protected]>
>
> ---
> v2:
> - Added 'Fixes:', 'Cc: stable' and 'Reviewed-by' tags
> ---
> arch/arm64/boot/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, I'll pick this up.

Will