2020-01-22 13:48:02

by Dafna Hirschfeld

Subject: [PATCH] dt-binding: fix compilation error of the example in qcom,gcc.yaml

Running `make dt_binging_check`, gives the error:

DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
Error: Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29 syntax error
FATAL ERROR: Unable to parse input tree

This is because the last example uses the macro RPM_SMD_XO_CLK_SRC which
is defined in qcom,rpmcc.h but the include of this header is missing.
Add the include to fix the error.

Signed-off-by: Dafna Hirschfeld <[email protected]>
---
Documentation/devicetree/bindings/clock/qcom,gcc.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
index 19d00794fe7d..50ff07f80acb 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
@@ -220,6 +220,7 @@ examples:

# Example of MSM8998 GCC:
- |
+ #include <dt-bindings/clock/qcom,rpmcc.h>
clock-controller@100000 {
compatible = "qcom,gcc-msm8998";
#clock-cells = <1>;
--
2.17.1

2020-01-23 14:27:42

by Rob Herring

Subject: Re: [PATCH] dt-binding: fix compilation error of the example in qcom,gcc.yaml

On Wed, Jan 22, 2020 at 7:46 AM Dafna Hirschfeld
<[email protected]> wrote:
>
> Running `make dt_binging_check`, gives the error:
>
> DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
> Error: Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29 syntax error
> FATAL ERROR: Unable to parse input tree
>
> This is because the last example uses the macro RPM_SMD_XO_CLK_SRC which
> is defined in qcom,rpmcc.h but the include of this header is missing.
> Add the include to fix the error.
>

Fixes: d109ea0970cf ("dt-bindings: clock: Document external clocks for
MSM8998 gcc")
Acked-by: Rob Herring <[email protected]>

> Signed-off-by: Dafna Hirschfeld <[email protected]>
> ---
> Documentation/devicetree/bindings/clock/qcom,gcc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> index 19d00794fe7d..50ff07f80acb 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> @@ -220,6 +220,7 @@ examples:
>
> # Example of MSM8998 GCC:
> - |
> + #include <dt-bindings/clock/qcom,rpmcc.h>
> clock-controller@100000 {
> compatible = "qcom,gcc-msm8998";
> #clock-cells = <1>;
> --
> 2.17.1
>

2020-01-28 18:27:36

by Stephen Boyd

Subject: Re: [PATCH] dt-binding: fix compilation error of the example in qcom,gcc.yaml

Quoting Dafna Hirschfeld (2020-01-22 05:46:39)
> Running `make dt_binging_check`, gives the error:
>
> DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
> Error: Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29 syntax error
> FATAL ERROR: Unable to parse input tree
>
> This is because the last example uses the macro RPM_SMD_XO_CLK_SRC which
> is defined in qcom,rpmcc.h but the include of this header is missing.
> Add the include to fix the error.
>
> Signed-off-by: Dafna Hirschfeld <[email protected]>
> ---

Applied to clk-next