2020-01-22 01:26:48

by Stephen Boyd

[permalink] [raw]

Subject: [PATCH] platform/chrome: wilco_ec: Allow wilco to be compiled in COMPILE_TEST

---

Enable this Kconfig on COMPILE_TEST enabled configs so we can get more
build coverage.

Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/platform/chrome/wilco_ec/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/wilco_ec/Kconfig b/drivers/platform/chrome/wilco_ec/Kconfig
index 365f30e116ee..49e8530ca0ac 100644
--- a/drivers/platform/chrome/wilco_ec/Kconfig
+++ b/drivers/platform/chrome/wilco_ec/Kconfig
@@ -1,7 +1,8 @@
# SPDX-License-Identifier: GPL-2.0-only
config WILCO_EC
tristate "ChromeOS Wilco Embedded Controller"
- depends on ACPI && X86 && CROS_EC_LPC && LEDS_CLASS
+ depends on X86 || COMPILE_TEST
+ depends on ACPI && CROS_EC_LPC && LEDS_CLASS
help
If you say Y here, you get support for talking to the ChromeOS
Wilco EC over an eSPI bus. This uses a simple byte-level protocol
--
Sent by a computer, using git, on the internet

2020-01-23 19:45:40

by Benson Leung

[permalink] [raw]

Subject: Re: [PATCH] platform/chrome: wilco_ec: Allow wilco to be compiled in COMPILE_TEST

---

Hi Stephen,

On Tue, Jan 21, 2020 at 05:24:34PM -0800, Stephen Boyd wrote:
> Enable this Kconfig on COMPILE_TEST enabled configs so we can get more
> build coverage.
>
> Signed-off-by: Stephen Boyd <[email protected]>

Applied to our for-next. Thanks!

> ---
> drivers/platform/chrome/wilco_ec/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/wilco_ec/Kconfig b/drivers/platform/chrome/wilco_ec/Kconfig
> index 365f30e116ee..49e8530ca0ac 100644
> --- a/drivers/platform/chrome/wilco_ec/Kconfig
> +++ b/drivers/platform/chrome/wilco_ec/Kconfig
> @@ -1,7 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config WILCO_EC
> tristate "ChromeOS Wilco Embedded Controller"
> - depends on ACPI && X86 && CROS_EC_LPC && LEDS_CLASS
> + depends on X86 || COMPILE_TEST
> + depends on ACPI && CROS_EC_LPC && LEDS_CLASS
> help
> If you say Y here, you get support for talking to the ChromeOS
> Wilco EC over an eSPI bus. This uses a simple byte-level protocol
> --
> Sent by a computer, using git, on the internet
>

--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
[email protected]
Chromium OS Project
[email protected]

---

Attachments:

(No filename) (1.22 kB)
signature.asc (235.00 B)
Download all attachments