2020-01-24 11:09:22

by Dafna Hirschfeld

Subject: [PATCH] dt-bindings: fix compilation error of the example in marvell,mmp3-hsic-phy.yaml

Running `make dt_binging_check`, gives the error:

DTC Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dt.yaml
Error: Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dts:20.41-42 syntax error
FATAL ERROR: Unable to parse input tree

This is because the example uses the macro GPIO_ACTIVE_HIGH which
is defined in gpio.h but the include of this header is missing.
Add the include to fix the error.

Signed-off-by: Dafna Hirschfeld <[email protected]>
---
Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
index 7917a95cda78..5ab436189f3b 100644
--- a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
@@ -33,6 +33,7 @@ required:

examples:
- |
+ #include <dt-bindings/gpio/gpio.h>
hsic-phy@f0001800 {
compatible = "marvell,mmp3-hsic-phy";
reg = <0xf0001800 0x40>;
--
2.17.1

2020-01-24 20:43:35

by Rob Herring

Subject: Re: [PATCH] dt-bindings: fix compilation error of the example in marvell,mmp3-hsic-phy.yaml

On Fri, Jan 24, 2020 at 4:58 AM Dafna Hirschfeld
<[email protected]> wrote:
>
> Running `make dt_binging_check`, gives the error:
>
> DTC Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dt.yaml
> Error: Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dts:20.41-42 syntax error
> FATAL ERROR: Unable to parse input tree
>
> This is because the example uses the macro GPIO_ACTIVE_HIGH which
> is defined in gpio.h but the include of this header is missing.
> Add the include to fix the error.
>
> Signed-off-by: Dafna Hirschfeld <[email protected]>

Fixes: f6f149604eef ("dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy")
Acked-by: Rob Herring <[email protected]>

Arnd, Olof, The above commit is in your tree. Please apply this.

Rob

2020-01-24 21:32:20

by Olof Johansson

Subject: Re: [PATCH] dt-bindings: fix compilation error of the example in marvell,mmp3-hsic-phy.yaml

On Fri, Jan 24, 2020 at 08:08:58AM -0600, Rob Herring wrote:
> On Fri, Jan 24, 2020 at 4:58 AM Dafna Hirschfeld
> <[email protected]> wrote:
> >
> > Running `make dt_binging_check`, gives the error:
> >
> > DTC Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dt.yaml
> > Error: Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dts:20.41-42 syntax error
> > FATAL ERROR: Unable to parse input tree
> >
> > This is because the example uses the macro GPIO_ACTIVE_HIGH which
> > is defined in gpio.h but the include of this header is missing.
> > Add the include to fix the error.
> >
> > Signed-off-by: Dafna Hirschfeld <[email protected]>
>
> Fixes: f6f149604eef ("dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy")
> Acked-by: Rob Herring <[email protected]>
>
> Arnd, Olof, The above commit is in your tree. Please apply this.

Applied.


Thanks,

-Olof