2020-02-01 13:00:07

by Madhuparna Bhowmik

Subject: [PATCH] sched.h: Annotate curr pointer in rq with __rcu

From: Madhuparna Bhowmik <[email protected]>

This patch fixes the following sparse errors in sched/core.c
and sched/membarrier.c
:
kernel/sched/core.c:2372:27: error: incompatible types in comparison expression
kernel/sched/core.c:4061:17: error: incompatible types in comparison expression
kernel/sched/core.c:6067:9: error: incompatible types in comparison expression
kernel/sched/membarrier.c:108:21: error: incompatible types in comparison expression
kernel/sched/membarrier.c:177:21: error: incompatible types in comparison expression
kernel/sched/membarrier.c:243:21: error: incompatible types in comparison expression

Signed-off-by: Madhuparna Bhowmik <[email protected]>
---
kernel/sched/sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 280a3c735935..97b1396b6008 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -896,7 +896,7 @@ struct rq {
*/
unsigned long nr_uninterruptible;

- struct task_struct *curr;
+ struct task_struct __rcu *curr;
struct task_struct *idle;
struct task_struct *stop;
unsigned long next_balance;
--
2.17.1

2020-02-11 12:50:51

by tip-bot2 for Alexey Makhalov

Subject: [tip: sched/urgent] sched/core: Annotate curr pointer in rq with __rcu

The following commit has been merged into the sched/urgent branch of tip:

Commit-ID: 4104a562e0ca62e971089db9d3c47794a0d7d4eb
Gitweb: https://git.kernel.org/tip/4104a562e0ca62e971089db9d3c47794a0d7d4eb
Author: Madhuparna Bhowmik <[email protected]>
AuthorDate: Sat, 01 Feb 2020 18:28:03 +05:30
Committer: Ingo Molnar <[email protected]>
CommitterDate: Tue, 11 Feb 2020 13:00:37 +01:00

sched/core: Annotate curr pointer in rq with __rcu

This patch fixes the following sparse warnings in sched/core.c
and sched/membarrier.c:

kernel/sched/core.c:2372:27: error: incompatible types in comparison expression
kernel/sched/core.c:4061:17: error: incompatible types in comparison expression
kernel/sched/core.c:6067:9: error: incompatible types in comparison expression
kernel/sched/membarrier.c:108:21: error: incompatible types in comparison expression
kernel/sched/membarrier.c:177:21: error: incompatible types in comparison expression
kernel/sched/membarrier.c:243:21: error: incompatible types in comparison expression

Signed-off-by: Madhuparna Bhowmik <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
kernel/sched/sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 5876e6b..9ea6478 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -896,7 +896,7 @@ struct rq {
*/
unsigned long nr_uninterruptible;

- struct task_struct *curr;
+ struct task_struct __rcu *curr;
struct task_struct *idle;
struct task_struct *stop;
unsigned long next_balance;