2020-02-02 22:32:00

by Dmitry Osipenko

Subject: [PATCH v7 11/19] dmaengine: tegra-apb: Remove pending_sg_req checking from tdc_start_head_req

There are only two places in the driver that use tdc_start_head_req()
and both these places check whether pending_sg_req list is empty before
invoking tdc_start_head_req().

Signed-off-by: Dmitry Osipenko <[email protected]>
---
drivers/dma/tegra20-apb-dma.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 22b88ccff05d..62d181bd5e62 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -504,9 +504,6 @@ static void tdc_start_head_req(struct tegra_dma_channel *tdc)
{
struct tegra_dma_sg_req *sg_req;

- if (list_empty(&tdc->pending_sg_req))
- return;
-
sg_req = list_first_entry(&tdc->pending_sg_req, typeof(*sg_req), node);
tegra_dma_start(tdc, sg_req);
sg_req->configured = true;
--
2.24.0

2020-02-04 14:55:42

by Jon Hunter

Subject: Re: [PATCH v7 11/19] dmaengine: tegra-apb: Remove pending_sg_req checking from tdc_start_head_req

On 02/02/2020 22:28, Dmitry Osipenko wrote:
> There are only two places in the driver that use tdc_start_head_req()
> and both these places check whether pending_sg_req list is empty before
> invoking tdc_start_head_req().
>
> Signed-off-by: Dmitry Osipenko <[email protected]>
> ---
> drivers/dma/tegra20-apb-dma.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index 22b88ccff05d..62d181bd5e62 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -504,9 +504,6 @@ static void tdc_start_head_req(struct tegra_dma_channel *tdc)
> {
> struct tegra_dma_sg_req *sg_req;
>
> - if (list_empty(&tdc->pending_sg_req))
> - return;
> -
> sg_req = list_first_entry(&tdc->pending_sg_req, typeof(*sg_req), node);
> tegra_dma_start(tdc, sg_req);
> sg_req->configured = true;
>

Acked-by: Jon Hunter <[email protected]>

Cheers
Jon

--
nvpublic