2020-02-04 09:03:16

by Chuanhong Guo

Subject: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621

There are 3 uarts on mt7621. This patch adds device tree node for
2nd and 2rd ones.

Signed-off-by: Chuanhong Guo <[email protected]>
---
drivers/staging/mt7621-dts/mt7621.dtsi | 38 ++++++++++++++++++++++++++
1 file changed, 38 insertions(+)

diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/staging/mt7621-dts/mt7621.dtsi
index d89d68ffa7bc..cee23710d03b 100644
--- a/drivers/staging/mt7621-dts/mt7621.dtsi
+++ b/drivers/staging/mt7621-dts/mt7621.dtsi
@@ -166,6 +166,44 @@ uartlite: uartlite@c00 {
no-loopback-test;
};

+ uartlite2: uartlite@d00 {
+ compatible = "ns16550a";
+ reg = <0xd00 0x100>;
+
+ clock-frequency = <50000000>;
+
+ interrupt-parent = <&gic>;
+ interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>;
+
+ reg-shift = <2>;
+ reg-io-width = <4>;
+ no-loopback-test;
+
+ status = "disabled";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart2_pins>;
+ };
+
+ uartlite3: uartlite@e00 {
+ compatible = "ns16550a";
+ reg = <0xe00 0x100>;
+
+ clock-frequency = <50000000>;
+
+ interrupt-parent = <&gic>;
+ interrupts = <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>;
+
+ reg-shift = <2>;
+ reg-io-width = <4>;
+ no-loopback-test;
+
+ status = "disabled";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart3_pins>;
+ };
+
spi0: spi@b00 {
status = "disabled";

--
2.24.1

2020-02-04 09:48:32

by Dan Carpenter

Subject: Re: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621

Please use ./scripts/get_maintainer.pl to pick the CC list and resend.

The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and
a couple other email lists.

regards,
dan carpenter

2020-02-04 10:00:44

by Chuanhong Guo

Subject: Re: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621

Hi!

On Tue, Feb 4, 2020 at 5:47 PM Dan Carpenter <[email protected]> wrote:
>
> Please use ./scripts/get_maintainer.pl to pick the CC list and resend.
>
> The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and
> a couple other email lists.

According to get_maintainer.pl, Matthias Brugger is the maintainer of
Mediatek ARM SoC:

Matthias Brugger <[email protected]> (maintainer:ARM/Mediatek SoC support)
[email protected] (moderated list:ARM/Mediatek SoC support)
[email protected] (moderated list:ARM/Mediatek SoC support)

I specifically removed the above 3 addresses because they are all for
Mediatek ARM chips
while mt7621 is a mips chip and belongs to ralink target under
/arch/mips/mach-ralink.
Code contribution for mt7621 goes through linux-mips instead of
linux-arm or linux-mediatek,

I thinks this is an incorrect setup of get_maintainer.pl and should be
corrected.

Regards,
Chuanhong Guo

2020-02-04 10:39:29

by Dan Carpenter

Subject: Re: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621

On Tue, Feb 04, 2020 at 05:59:21PM +0800, Chuanhong Guo wrote:
> Hi!
>
> On Tue, Feb 4, 2020 at 5:47 PM Dan Carpenter <[email protected]> wrote:
> >
> > Please use ./scripts/get_maintainer.pl to pick the CC list and resend.
> >
> > The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and
> > a couple other email lists.
>
> According to get_maintainer.pl, Matthias Brugger is the maintainer of
> Mediatek ARM SoC:
>
> Matthias Brugger <[email protected]> (maintainer:ARM/Mediatek SoC support)
> [email protected] (moderated list:ARM/Mediatek SoC support)
> [email protected] (moderated list:ARM/Mediatek SoC support)
>
> I specifically removed the above 3 addresses because they are all for
> Mediatek ARM chips
> while mt7621 is a mips chip and belongs to ralink target under
> /arch/mips/mach-ralink.
> Code contribution for mt7621 goes through linux-mips instead of
> linux-arm or linux-mediatek,

I would have thought that we would still CC linux-mediatek?

>
> I thinks this is an incorrect setup of get_maintainer.pl and should be
> corrected.

We could ask him...

It's always easiest to fix MAINTAINERS instead of remembering all the
exceptions and rules.

regards,
dan carpenter