2020-02-04 11:40:37

by Thomas Bogendoerfer

Subject: [PATCH] serial: 8250_ioc3: Fix ioremap call

Commit 4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache")
removed devm_ioremap_nocache, but 8250_ioc3 wasn't upstream at that
time. So fix 8250_ioc3 by using devm_ioremap.

Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
Signed-off-by: Thomas Bogendoerfer <[email protected]>
---
drivers/tty/serial/8250/8250_ioc3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_ioc3.c b/drivers/tty/serial/8250/8250_ioc3.c
index 4c405f1b9c67..d5a39e105a76 100644
--- a/drivers/tty/serial/8250/8250_ioc3.c
+++ b/drivers/tty/serial/8250/8250_ioc3.c
@@ -47,7 +47,7 @@ static int serial8250_ioc3_probe(struct platform_device *pdev)
if (!data)
return -ENOMEM;

- membase = devm_ioremap_nocache(&pdev->dev, r->start, resource_size(r));
+ membase = devm_ioremap(&pdev->dev, r->start, resource_size(r));
if (!membase)
return -ENOMEM;

--
2.24.1

2020-02-04 14:41:02

by Andy Shevchenko

Subject: Re: [PATCH] serial: 8250_ioc3: Fix ioremap call

On Tue, Feb 4, 2020 at 1:40 PM Thomas Bogendoerfer
<[email protected]> wrote:
>
> Commit 4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache")
> removed devm_ioremap_nocache, but 8250_ioc3 wasn't upstream at that
> time. So fix 8250_ioc3 by using devm_ioremap.
>

Reviewed-by: Andy Shevchenko <[email protected]>

> Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")

Basically it happened due to ioremap_nocache() removal, but it really
doesn't matter because in this case no functional change is expected.

> Signed-off-by: Thomas Bogendoerfer <[email protected]>
> ---
> drivers/tty/serial/8250/8250_ioc3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_ioc3.c b/drivers/tty/serial/8250/8250_ioc3.c
> index 4c405f1b9c67..d5a39e105a76 100644
> --- a/drivers/tty/serial/8250/8250_ioc3.c
> +++ b/drivers/tty/serial/8250/8250_ioc3.c
> @@ -47,7 +47,7 @@ static int serial8250_ioc3_probe(struct platform_device *pdev)
> if (!data)
> return -ENOMEM;
>
> - membase = devm_ioremap_nocache(&pdev->dev, r->start, resource_size(r));
> + membase = devm_ioremap(&pdev->dev, r->start, resource_size(r));
> if (!membase)
> return -ENOMEM;
>
> --
> 2.24.1
>


--
With Best Regards,
Andy Shevchenko

2020-02-10 19:35:15

by Greg Kroah-Hartman

Subject: Re: [PATCH] serial: 8250_ioc3: Fix ioremap call

On Tue, Feb 04, 2020 at 12:39:12PM +0100, Thomas Bogendoerfer wrote:
> Commit 4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache")
> removed devm_ioremap_nocache, but 8250_ioc3 wasn't upstream at that
> time. So fix 8250_ioc3 by using devm_ioremap.
>
> Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
> Signed-off-by: Thomas Bogendoerfer <[email protected]>
> ---
> drivers/tty/serial/8250/8250_ioc3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_ioc3.c b/drivers/tty/serial/8250/8250_ioc3.c
> index 4c405f1b9c67..d5a39e105a76 100644
> --- a/drivers/tty/serial/8250/8250_ioc3.c
> +++ b/drivers/tty/serial/8250/8250_ioc3.c
> @@ -47,7 +47,7 @@ static int serial8250_ioc3_probe(struct platform_device *pdev)
> if (!data)
> return -ENOMEM;
>
> - membase = devm_ioremap_nocache(&pdev->dev, r->start, resource_size(r));
> + membase = devm_ioremap(&pdev->dev, r->start, resource_size(r));
> if (!membase)
> return -ENOMEM;

Looks like Linus already fixed this in b0ef7cda8d9b ("Fix up remaining
devm_ioremap_nocache() in SGI IOC3 8250 UART driver")