2020-02-07 18:04:29

by Steven Moreland

Subject: [PATCH v3] security: selinux: allow per-file labeling for bpffs

From: Connor O'Brien <[email protected]>

Add support for genfscon per-file labeling of bpffs files. This allows
for separate permissions for different pinned bpf objects, which may
be completely unrelated to each other.

Signed-off-by: Connor O'Brien <[email protected]>
Signed-off-by: Steven Moreland <[email protected]>
---
security/selinux/hooks.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index d9e8b2131a65..18f8cd47729c 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -699,6 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
if (!strcmp(sb->s_type->name, "debugfs") ||
!strcmp(sb->s_type->name, "tracefs") ||
!strcmp(sb->s_type->name, "binderfs") ||
+ !strcmp(sb->s_type->name, "bpf") ||
!strcmp(sb->s_type->name, "pstore"))
sbsec->flags |= SE_SBGENFS;

--
2.25.0.341.g760bfbb309-goog

v2 -> v3
- on selinux next branch (instead of master)

2020-02-07 18:12:43

by Stephen Smalley

Subject: Re: [PATCH v3] security: selinux: allow per-file labeling for bpffs

On 2/7/20 1:01 PM, Steven Moreland wrote:
> From: Connor O'Brien <[email protected]>
>
> Add support for genfscon per-file labeling of bpffs files. This allows
> for separate permissions for different pinned bpf objects, which may
> be completely unrelated to each other.
>
> Signed-off-by: Connor O'Brien <[email protected]>
> Signed-off-by: Steven Moreland <[email protected]>

Acked-by: Stephen Smalley <[email protected]>

> ---
> security/selinux/hooks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index d9e8b2131a65..18f8cd47729c 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -699,6 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
> if (!strcmp(sb->s_type->name, "debugfs") ||
> !strcmp(sb->s_type->name, "tracefs") ||
> !strcmp(sb->s_type->name, "binderfs") ||
> + !strcmp(sb->s_type->name, "bpf") ||
> !strcmp(sb->s_type->name, "pstore"))
> sbsec->flags |= SE_SBGENFS;
>
>

2020-02-12 03:08:12

by Paul Moore

Subject: Re: [PATCH v3] security: selinux: allow per-file labeling for bpffs

On Fri, Feb 7, 2020 at 1:02 PM Steven Moreland <[email protected]> wrote:
>
> From: Connor O'Brien <[email protected]>
>
> Add support for genfscon per-file labeling of bpffs files. This allows
> for separate permissions for different pinned bpf objects, which may
> be completely unrelated to each other.
>
> Signed-off-by: Connor O'Brien <[email protected]>
> Signed-off-by: Steven Moreland <[email protected]>
> ---
> security/selinux/hooks.c | 1 +
> 1 file changed, 1 insertion(+)

Merged into selinux/next, thanks.

--
paul moore
http://www.paul-moore.com