2020-02-10 08:15:20

by Chen Wandun

Subject: [PATCH next] mptcp: make the symbol 'mptcp_sk_clone_lock' static

Fix the following sparse warning:
net/mptcp/protocol.c:646:13: warning: symbol 'mptcp_sk_clone_lock' was not declared. Should it be static?

Fixes: b0519de8b3f1 ("mptcp: fix use-after-free for ipv6")
Signed-off-by: Chen Wandun <[email protected]>
---
net/mptcp/protocol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index 73780b4cb108..030dee668e0a 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -643,7 +643,7 @@ static struct ipv6_pinfo *mptcp_inet6_sk(const struct sock *sk)
}
#endif

-struct sock *mptcp_sk_clone_lock(const struct sock *sk)
+static struct sock *mptcp_sk_clone_lock(const struct sock *sk)
{
struct sock *nsk = sk_clone_lock(sk, GFP_ATOMIC);

--
2.17.1

2020-02-10 09:25:43

by David Miller

Subject: Re: [PATCH next] mptcp: make the symbol 'mptcp_sk_clone_lock' static

From: Chen Wandun <[email protected]>
Date: Mon, 10 Feb 2020 16:27:59 +0800

> Fix the following sparse warning:
> net/mptcp/protocol.c:646:13: warning: symbol 'mptcp_sk_clone_lock' was not declared. Should it be static?
>
> Fixes: b0519de8b3f1 ("mptcp: fix use-after-free for ipv6")
> Signed-off-by: Chen Wandun <[email protected]>

Applied.