2020-01-22 08:25:06

by Arun Kumar Neelakantam

Subject: [PATCH] soc: qcom: aoss: Use wake_up_all() instead of wake_up_interruptible_all()

During the probe the task is waiting in TASK_UNINTERRUPTIBLE state which
cannot be woken-up by wake_up_interruptible_all() function.

Use wake_up_all() to wake-up both TASK_UNINTERRUPTIBLE and
TASK_INTERRUPTIBLE state tasks.

Signed-off-by: Arun Kumar Neelakantam <[email protected]>
---
drivers/soc/qcom/qcom_aoss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
index 006ac40..fe79661 100644
--- a/drivers/soc/qcom/qcom_aoss.c
+++ b/drivers/soc/qcom/qcom_aoss.c
@@ -200,7 +200,7 @@ static irqreturn_t qmp_intr(int irq, void *data)
{
struct qmp *qmp = data;

- wake_up_interruptible_all(&qmp->event);
+ wake_up_all(&qmp->event);

return IRQ_HANDLED;
}
--
1.9.1

2020-02-12 06:32:20

by Bjorn Andersson

Subject: Re: [PATCH] soc: qcom: aoss: Use wake_up_all() instead of wake_up_interruptible_all()

On Wed 22 Jan 00:23 PST 2020, Arun Kumar Neelakantam wrote:

> During the probe the task is waiting in TASK_UNINTERRUPTIBLE state which
> cannot be woken-up by wake_up_interruptible_all() function.
>
> Use wake_up_all() to wake-up both TASK_UNINTERRUPTIBLE and
> TASK_INTERRUPTIBLE state tasks.
>
> Signed-off-by: Arun Kumar Neelakantam <[email protected]>

Applied

Regards,
Bjorn

> ---
> drivers/soc/qcom/qcom_aoss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
> index 006ac40..fe79661 100644
> --- a/drivers/soc/qcom/qcom_aoss.c
> +++ b/drivers/soc/qcom/qcom_aoss.c
> @@ -200,7 +200,7 @@ static irqreturn_t qmp_intr(int irq, void *data)
> {
> struct qmp *qmp = data;
>
> - wake_up_interruptible_all(&qmp->event);
> + wake_up_all(&qmp->event);
>
> return IRQ_HANDLED;
> }
> --
> 1.9.1