2020-02-12 15:56:15

by Balakrishna Godavarthi

Subject: [PATCH v2] arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990

Add bluetooth SoC node for SC7180 IDP board.

Signed-off-by: Balakrishna Godavarthi <[email protected]>
---
v2:
* updated commit text
* removed status form dts node
---
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 388f50ad4fde..7a50a439b6f3 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -19,6 +19,7 @@
aliases {
hsuart0 = &uart3;
serial0 = &uart8;
+ bluetooth0 = &bluetooth;
};

chosen {
@@ -256,6 +257,16 @@

&uart3 {
status = "okay";
+
+ bluetooth: wcn3990-bt {
+ compatible = "qcom,wcn3990-bt";
+ vddio-supply = <&vreg_l10a_1p8>;
+ vddxo-supply = <&vreg_l1c_1p8>;
+ vddrf-supply = <&vreg_l2c_1p3>;
+ vddch0-supply = <&vreg_l10c_3p3>;
+ max-speed = <3200000>;
+ clocks = <&rpmhcc RPMH_RF_CLK2>;
+ };
};

&uart8 {
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2020-02-12 18:31:59

by Matthias Kaehlcke

Subject: Re: [PATCH v2] arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990

On Wed, Feb 12, 2020 at 09:24:19PM +0530, Balakrishna Godavarthi wrote:

> Subject: arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990

The subject still suggests that this is relevant for all SC7180 boards
that use the WCN3990 for Bluetooth. Please in the future save folks time
and make it clear in the *subject* that this is for a specific board
(the IDP).

> Add bluetooth SoC node for SC7180 IDP board.
>
> Signed-off-by: Balakrishna Godavarthi <[email protected]>
> ---
> v2:
> * updated commit text
> * removed status form dts node
> ---
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 388f50ad4fde..7a50a439b6f3 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -19,6 +19,7 @@
> aliases {
> hsuart0 = &uart3;
> serial0 = &uart8;
> + bluetooth0 = &bluetooth;

nit: it would be nicer to have the aliases in alphabetical order.

> };
>
> chosen {
> @@ -256,6 +257,16 @@
>
> &uart3 {
> status = "okay";
> +
> + bluetooth: wcn3990-bt {
> + compatible = "qcom,wcn3990-bt";
> + vddio-supply = <&vreg_l10a_1p8>;
> + vddxo-supply = <&vreg_l1c_1p8>;
> + vddrf-supply = <&vreg_l2c_1p3>;
> + vddch0-supply = <&vreg_l10c_3p3>;
> + max-speed = <3200000>;
> + clocks = <&rpmhcc RPMH_RF_CLK2>;
> + };
> };
>
> &uart8 {

Reviewed-by: Matthias Kaehlcke <[email protected]>